-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Catalog] Support Unpublish Catalog Content #7753
[Catalog] Support Unpublish Catalog Content #7753
Conversation
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #7753 +/- ##
==========================================
- Coverage 11.09% 11.07% -0.02%
==========================================
Files 123 123
Lines 17059 17080 +21
==========================================
Hits 1892 1892
- Misses 14865 14886 +21
Partials 302 302
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
…alog/unpublish Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
🚀 Preview for commit f9f31b6 at: https://6480f9ee7fdf134a591bfaff--meshery-docs-preview.netlify.app |
This PR also fixes a recent bug that removed GraphQL subscriptions from patterns page and removed catalog view preference logic. |
🚀 Preview for commit d3cf744 at: https://6482a2f2d2034314c425df45--meshery-docs-preview.netlify.app |
🚀 Preview for commit f61443c at: https://648330fe617b4b10c8969110--meshery-docs-preview.netlify.app |
@Abhishek-kumar09 @MUzairS15 |
…alog/unpublish Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
🚀 Preview for commit c53dd19 at: https://6487224a58602d366e8b9fb1--meshery-docs-preview.netlify.app |
Notes for Reviewers
This PR adds support for Meshery users to unpublished a catalog item.
Only admins or curators are allowed this action.
Steps:
visibility
frompublished
toprivate
demo:
Screen.Recording.2023-06-08.at.3.02.34.AM.mov
This PR fixes #
Error message for non-admins or non-curators:
Signed commits