Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Catalog] Support Unpublish Catalog Content #7753

Merged

Conversation

theBeginner86
Copy link
Member

@theBeginner86 theBeginner86 commented May 30, 2023

Notes for Reviewers

This PR adds support for Meshery users to unpublished a catalog item.
Only admins or curators are allowed this action.

Steps:

  1. Updates the visibility from published to private
  2. Removes the items from the https://meshery.io/catalog by calling a webhook to the workflow

demo:

Screen.Recording.2023-06-08.at.3.02.34.AM.mov

This PR fixes #

Error message for non-admins or non-curators:

Screenshot 2023-06-08 at 3 16 14 AM

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (297877c) 11.09% compared to head (c53dd19) 11.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7753      +/-   ##
==========================================
- Coverage   11.09%   11.07%   -0.02%     
==========================================
  Files         123      123              
  Lines       17059    17080      +21     
==========================================
  Hits         1892     1892              
- Misses      14865    14886      +21     
  Partials      302      302              
Flag Coverage Δ
unittests 11.07% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/handlers/meshery_pattern_handler.go 0.00% <0.00%> (ø)
server/router/server.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@github-actions github-actions bot added the component/ui User Interface label Jun 7, 2023
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@theBeginner86 theBeginner86 changed the title [WIP][Catalog] Support Unpublish Catalog Content [Catalog] Support Unpublish Catalog Content Jun 7, 2023
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@github-actions github-actions bot added the area/docs Documentation update needed label Jun 7, 2023
…alog/unpublish

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@l5io
Copy link
Collaborator

l5io commented Jun 7, 2023

@theBeginner86 theBeginner86 removed the pr/do-not-merge PRs not ready to be merged label Jun 7, 2023
@theBeginner86
Copy link
Member Author

theBeginner86 commented Jun 7, 2023

This PR also fixes a recent bug that removed GraphQL subscriptions from patterns page and removed catalog view preference logic.

@l5io
Copy link
Collaborator

l5io commented Jun 9, 2023

@l5io
Copy link
Collaborator

l5io commented Jun 9, 2023

@theBeginner86
Copy link
Member Author

theBeginner86 commented Jun 9, 2023

@Abhishek-kumar09 @MUzairS15
Any comments here? ok to move forward here?

…alog/unpublish

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@github-actions
Copy link

@l5io
Copy link
Collaborator

l5io commented Jun 12, 2023

@theBeginner86 theBeginner86 merged commit 218707f into meshery:master Jun 12, 2023
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants