Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove mapping navigator #7806

Merged

Conversation

Udit-takkar
Copy link
Contributor

@Udit-takkar Udit-takkar commented Jun 7, 2023

Notes for Reviewers

This PR fixes Follow up https://github.com/meshery/meshery/pull/7728/files#r1204849350. added isBeta property here https://github.com/layer5io/meshery-cloud/pull/850

Signed commits

  • Yes, I signed my commits.

@github-actions github-actions bot added the component/ui User Interface label Jun 7, 2023
Copy link
Member

@theBeginner86 theBeginner86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this ready for review?

@theBeginner86 theBeginner86 added the kind/chore Necessary task label Jun 8, 2023
@theBeginner86 theBeginner86 mentioned this pull request Jun 8, 2023
1 task
Copy link
Member

@theBeginner86 theBeginner86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh-oh, a merge conflict to resolve...

@theBeginner86
Copy link
Member

When I built your PR locally, then I wasn’t seeing BETA label on MeshMap. Would you please confirm from your end?

Just to be sure that I wasn’t having any build cache

@leecalcote
Copy link
Member

A couple of merge conflicts to look at @Udit-takkar ...

Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
@github-actions
Copy link

github-actions bot commented Jun 17, 2023

@codecov
Copy link

codecov bot commented Jun 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: +3.99 🎉

Comparison is base (7ebcee2) 11.07% compared to head (f1b7010) 15.06%.

❗ Current head f1b7010 differs from pull request most recent head 5813766. Consider uploading reports for the commit 5813766 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7806      +/-   ##
==========================================
+ Coverage   11.07%   15.06%   +3.99%     
==========================================
  Files         123      123              
  Lines       17101    17101              
==========================================
+ Hits         1894     2577     +683     
+ Misses      14905    14059     -846     
- Partials      302      465     +163     
Flag Coverage Δ
e2etests ∅ <ø> (?)
gointegrationtests 5.34% <ø> (?)
unittests 11.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@theBeginner86 theBeginner86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@theBeginner86 theBeginner86 merged commit c5c4fc0 into meshery:master Jun 17, 2023
14 checks passed
@theBeginner86
Copy link
Member

Thanks @Udit-takkar for seeing through this diligently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants