-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove mapping navigator #7806
fix: remove mapping navigator #7806
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this ready for review?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh-oh, a merge conflict to resolve...
When I built your PR locally, then I wasn’t seeing BETA label on MeshMap. Would you please confirm from your end?
|
A couple of merge conflicts to look at @Udit-takkar ... |
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
ca6a9a9
to
f1b7010
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #7806 +/- ##
==========================================
+ Coverage 11.07% 15.06% +3.99%
==========================================
Files 123 123
Lines 17101 17101
==========================================
+ Hits 1894 2577 +683
+ Misses 14905 14059 -846
- Partials 302 465 +163
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
Thanks @Udit-takkar for seeing through this diligently |
Notes for Reviewers
This PR fixes Follow up https://github.com/meshery/meshery/pull/7728/files#r1204849350. added isBeta property here https://github.com/layer5io/meshery-cloud/pull/850
Signed commits