-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Published icon fix in design card #7808
Conversation
Signed-off-by: Vivek jha <85884487+duckling69@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @duckling69 ! ✨
Just couple of points to add on:
- Can we make the font text to bold for better readability?
- Can we use CSS variables instead of hard-coding color values?
Rest looks perfect!
Looks like we are failing some checks ,
Phew, An indentation can indeed cause failure of checks🥲 |
Signed-off-by: Lee Calcote <leecalcote@gmail.com>
Signed-off-by: Lee Calcote <leecalcote@gmail.com>
Notes for Reviewers
This PR fixes #7682
After fix
Signed commits