Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix golang-ci lint test #7810

Merged
merged 2 commits into from
Jun 8, 2023
Merged

fix golang-ci lint test #7810

merged 2 commits into from
Jun 8, 2023

Conversation

ayushthe1
Copy link
Contributor

Notes for Reviewers

This PR fixes #7761

Signed commits

  • Yes, I signed my commits.

Signed-off-by: ayushthe1 <ayushsharmaa101@gmail.com>
@ayushthe1
Copy link
Contributor Author

@theBeginner86 @Aisuko I haven't removed the unused functions from docs.go file as you discussed. Thats why the test are failing. I'll exclude it from the lint tests. Meanwhile please review this PR as I have removed many more unused functions which might be needed.

@Aisuko
Copy link
Member

Aisuko commented Jun 8, 2023

I have to add ignore file to make sure we can fix most parts of the golangci-lint issues.

Copy link
Member

@Aisuko Aisuko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aisuko Aisuko merged commit 6c8565d into meshery:master Jun 8, 2023
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixing the CI issues
2 participants