[CI] Support Edge Releases with Remote Provider #7913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
|
|
leecalcote
reviewed
Jun 23, 2023
| @@ -27,10 +27,13 @@ jobs: | |||
| password: ${{ secrets.DOCKER_PASSWORD }} | |||
| - name: Docker edge build & tag | |||
| run: | | |||
| DOCKER_BUILDKIT=1 docker build -f install/docker/Dockerfile --no-cache -t ${{ secrets.IMAGE_NAME }}:edge-latest --build-arg TOKEN=${{ secrets.GLOBAL_TOKEN }} --build-arg GIT_COMMITSHA=${GITHUB_SHA::8} --build-arg GIT_VERSION="edge-latest" --build-arg RELEASE_CHANNEL=${RELEASE_CHANNEL} . | |||
There was a problem hiding this comment.
The edge-latest still gets included, right? We're just adding a release number tag, too.
There was a problem hiding this comment.
Can you offer an example of what the "release number" will be for an edge release? edge-v0.6.99-1? Or are we going to keep overwriting the same tag edge-v0.6.99 until a new stable release is made?
There was a problem hiding this comment.
I see that the latter is true. ✅
leecalcote
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR updates the edge release workflow for
Would allow edge release users to use any remote provider while logging into Meshery
This PR fixes #7850
Signed commits