[UI] Add support to download, publish, unpublish, and clone wasm support #7969

Chadha93 · 2023-06-28T13:02:42Z

Signed-off-by: Gaurav Chadha gauravchadha1676@gmail.com
Notes for Reviewers
Add support to download, publish, unpublish, and clone wasm support.

WASM.mp4

This PR fixes #CU-863h1z6br

Signed commits

Yes, I signed my commits.

Signed-off-by: Gaurav Chadha <gauravchadha1676@gmail.com>

l5io · 2023-06-28T13:02:44Z

Task linked: CU-863h1z6br WASM Filters

github-actions · 2023-06-28T13:04:13Z

Signed-off-by: Gaurav Chadha <gauravchadha1676@gmail.com>

Chadha93 · 2023-06-28T13:07:42Z

@Abhishek-kumar09 @theBeginner86, all the filters are having the visibility as private...

theBeginner86 · 2023-06-28T13:10:51Z

@Abhishek-kumar09 @theBeginner86, all the filters are having the visibility as private...

Yes that's true. It's because we haven't published any Filters to catalog so far.

Here, publishing to catalog means publishing from Meshery UI using our dispatch workflow and setting visibility as published. The ones which we see at https://meshery.io/catalog/webassembly are the hardcoded ones.

leecalcote · 2023-06-28T17:56:46Z

@aabidsofi19 what comments do you have here?

aabidsofi19 · 2023-06-29T13:22:54Z

ui/utils/fileDownloader.js

@@ -12,6 +12,10 @@ export default function downloadFile({ id, type,name, source_type }) {
    dataUri = `/api/pattern/download/${id}`;
  }

+  if (type === "filter") {


As we are having a bunch of these if statements , we might try using a object to map type to path , also having source_type and type together make the function little complex , hence maybe be prone to bugs ( something to consider)

Sounds appropriate to me. @aabidsofi19 will you jump in with a code suggestion (make a commit to this PR/branch)?

aabidsofi19 · 2023-06-29T13:25:46Z

ui/components/Filters.js

+        if (filtersCatalogueCapability?.length > 0) setCanPublishFilter(true);
+      }
+    },
+    (err) => console.error(err)


can we do something more with the error .

Yes, please, @Chadha93. A toaster?

leecalcote · 2023-06-30T01:02:35Z

ui/components/Filters.js

+    },
+    PUBLISH_CATALOG : {
+      name : "PUBLISH_CATALOG",
+      error_msg : "Failed to publish catalog"


What does this mean? "Failed to publish catalog"

Please rephrase.

Rephrase. Include filter name or filename as confirmation for the user.

leecalcote · 2023-06-30T01:03:05Z

ui/components/Filters.js

+    },
+    UNPUBLISH_CATALOG : {
+      name : "PUBLISH_CATALOG",
+      error_msg : "Failed to publish catalog"


Rephrase. Include filter name or filename as confirmation for the user.

leecalcote · 2023-06-30T01:03:38Z

ui/components/Filters.js

+        if (filtersCatalogueCapability?.length > 0) setCanPublishFilter(true);
+      }
+    },
+    (err) => console.error(err)


Yes, please, @Chadha93. A toaster?

leecalcote · 2023-06-30T01:04:38Z

ui/components/Filters.js

+                { credentials : "include", method : "DELETE", body : JSON.stringify({ "id" : filter?.id }) },
+                () => {
+                  updateProgress({ showProgress : false });
+                  enqueueSnackbar("Filter unpublished", {


What filter? Provide the name as confirmation to the user.

@Chadha93, remember when you had to go through the code base and make the notifications uniform by adding the name of the thing into the toaster message... ? Please uphold this convention.

leecalcote · 2023-06-30T01:05:18Z

ui/components/Filters.js

@@ -224,9 +234,39 @@ function MesheryFilters({ updateProgress, enqueueSnackbar, closeSnackbar, user,
    CLONE_FILTERS : {
      name : "CLONE_FILTER",
      error_msg : "Failed to clone filter file"
+    },
+    PUBLISH_CATALOG : {
+      name : "PUBLISH_CATALOG",


This name is a bit of a misnomer, no? Please rename accordingly.

leecalcote · 2023-06-30T01:06:30Z

ui/components/Filters.js

+      return async () => {
+        let response = await modalRef.current.show({
+          title : `Unpublish Catalog item?`,
+          subtitle : `Are you sure you want to unpublish ${filter?.name}?`,


Suggested change

subtitle : `Are you sure you want to unpublish ${filter?.name}?`,

subtitle : `Are you sure that you want to unpublish "${filter?.name}"?`,

leecalcote · 2023-06-30T01:07:33Z

ui/components/Filters.js

+      { credentials : "include", method : "POST", body : JSON.stringify(catalog_data) },
+      () => {
+        updateProgress({ showProgress : false });
+        enqueueSnackbar("Filter Published!", {


Why are you capitalizing "Published"? Please don't.

Also, please don't yell at the user! It's not nice, is it?

leecalcote · 2023-06-30T01:07:47Z

ui/components/Filters.js

+    try {
+      downloadFile({ id, name, type : "filter" })
+      updateProgress({ showProgress : false });
+      enqueueSnackbar(`"${name}" Filter downloaded`, {


What filter?

leecalcote · 2023-06-30T01:07:59Z

ui/components/Filters.js

+        }
+      });
+    } catch (e) {
+      console.error(e);


What are we doing when this happens?

leecalcote · 2023-06-30T01:09:49Z

ui/utils/fileDownloader.js

@@ -12,6 +12,10 @@ export default function downloadFile({ id, type,name, source_type }) {
    dataUri = `/api/pattern/download/${id}`;
  }

+  if (type === "filter") {


Sounds appropriate to me. @aabidsofi19 will you jump in with a code suggestion (make a commit to this PR/branch)?

leecalcote · 2023-06-30T13:42:04Z

Urgently needed. Merging. Please follow up on comments.

Chadha93 · 2023-06-30T13:51:22Z

Urgently needed. Merging. Please follow up on comments.

Working on comments, I just checked the publish is breaking for filters, as Publish modal was not updated.

Chadha93 added 3 commits June 28, 2023 18:28

download wasm support

92eddf1

Signed-off-by: Gaurav Chadha <gauravchadha1676@gmail.com>

add filters catalog enum

2bbdb19

Signed-off-by: Gaurav Chadha <gauravchadha1676@gmail.com>

update wasm filters ui

3c0f89f

Signed-off-by: Gaurav Chadha <gauravchadha1676@gmail.com>

Chadha93 requested review from Abhishek-kumar09, theBeginner86 and MUzairS15 June 28, 2023 13:02

Chadha93 requested a review from leecalcote June 28, 2023 13:02

github-actions bot added the component/ui User Interface label Jun 28, 2023

fix-lint

6cd5698

Signed-off-by: Gaurav Chadha <gauravchadha1676@gmail.com>

leecalcote requested a review from aabidsofi19 June 28, 2023 17:56

aabidsofi19 reviewed Jun 29, 2023

View reviewed changes

leecalcote requested changes Jun 30, 2023

View reviewed changes

Merge branch 'master' into wasm-ui-support

0227342

leecalcote merged commit 5b153a4 into meshery:master Jun 30, 2023
15 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[UI] Add support to download, publish, unpublish, and clone wasm support #7969

[UI] Add support to download, publish, unpublish, and clone wasm support #7969

Chadha93 commented Jun 28, 2023 •

edited

l5io commented Jun 28, 2023

github-actions bot commented Jun 28, 2023 •

edited

Chadha93 commented Jun 28, 2023

theBeginner86 commented Jun 28, 2023 •

edited

leecalcote commented Jun 28, 2023

aabidsofi19 Jun 29, 2023

leecalcote Jun 30, 2023

aabidsofi19 Jun 29, 2023

leecalcote Jun 30, 2023

leecalcote Jun 30, 2023

leecalcote Jun 30, 2023

leecalcote Jun 30, 2023

leecalcote Jun 30, 2023

leecalcote Jun 30, 2023

leecalcote Jun 30, 2023

leecalcote Jun 30, 2023

leecalcote Jun 30, 2023

leecalcote Jun 30, 2023

leecalcote Jun 30, 2023

leecalcote Jun 30, 2023

leecalcote commented Jun 30, 2023

Chadha93 commented Jun 30, 2023

	subtitle : `Are you sure you want to unpublish ${filter?.name}?`,
	subtitle : `Are you sure that you want to unpublish "${filter?.name}"?`,

[UI] Add support to download, publish, unpublish, and clone wasm support #7969

[UI] Add support to download, publish, unpublish, and clone wasm support #7969

Conversation

Chadha93 commented Jun 28, 2023 • edited

l5io commented Jun 28, 2023

github-actions bot commented Jun 28, 2023 • edited

Chadha93 commented Jun 28, 2023

theBeginner86 commented Jun 28, 2023 • edited

leecalcote commented Jun 28, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

leecalcote commented Jun 30, 2023

Chadha93 commented Jun 30, 2023

Chadha93 commented Jun 28, 2023 •

edited

github-actions bot commented Jun 28, 2023 •

edited

theBeginner86 commented Jun 28, 2023 •

edited