Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filters] Add Support For Unpublish Filters in Server #7970

Merged

Conversation

theBeginner86
Copy link
Member

Notes for Reviewers

This PR adds API and handlers for unpublishing catalog filters from Meshery UI

This PR fixes #

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@github-actions
Copy link

github-actions bot commented Jun 28, 2023

@l5io
Copy link
Collaborator

l5io commented Jun 28, 2023

Copy link
Member

@Chadha93 Chadha93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: +9.67 🎉

Comparison is base (01793fc) 5.32% compared to head (2d06d8c) 14.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7970      +/-   ##
==========================================
+ Coverage    5.32%   14.99%   +9.67%     
==========================================
  Files         124      124              
  Lines       17172    17193      +21     
==========================================
+ Hits          914     2578    +1664     
+ Misses      16086    14150    -1936     
- Partials      172      465     +293     
Flag Coverage Δ
gointegrationtests 5.31% <0.00%> (-0.01%) ⬇️
unittests 11.02% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/handlers/meshery_filter_handler.go 0.00% <0.00%> (ø)
server/router/server.go 0.00% <0.00%> (ø)

... and 37 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@theBeginner86 theBeginner86 merged commit da7dae6 into meshery:master Jun 29, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants