[Performance] Add support to use SSL certs for load testing. #8023
Conversation
Signed-off-by: MUzairS15 <muzair.shaikh810@gmail.com>
Signed-off-by: MUzairS15 <muzair.shaikh810@gmail.com>
MUzairS15
added
area/performance
|
|
|
One or two items are to be completed before merging. |
|
This PR has been labeled with 'component/ui'. 🧰 Here are docs on Contributing to Meshery UI. 🎨 Here is the Meshery UI Figma File File. Lastly, here are docs on Contributing to Meshery's End-to-End Tests Using Cypress
|
Signed-off-by: Mohd Uzair <muzair.shaikh810@gmail.com>
|
// @leecalcote |
|
This is for Fortio only, it modifies the performance profile to be able to capture and associate a single file, right? |
|
Yes and use them while load testing, to my knowledge nighthawk doesn’t support this. |
| When "cert" query param is set the body contains self-signed certs | ||
| and not the SMP config, hence we shouldn't use SMP Handler, | ||
| if query param is unset/not present presence of body | ||
| if values have been passed as body we run test using SMP Handler | ||
| */ |
There was a problem hiding this comment.
Can we add "cert" as a param in the SMP config?
There was a problem hiding this comment.
Yes, we should add. // service-mesh-performance/service-mesh-performance#389
Signed-off-by: MUzairS15 <muzair.shaikh810@gmail.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #8023 +/- ##
=========================================
- Coverage 5.23% 5.20% -0.03%
=========================================
Files 124 124
Lines 17473 17548 +75
=========================================
Hits 914 914
- Misses 16387 16462 +75
Partials 172 172
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
@abhi |
|
@MUzairS15 Let's discuss this on Meshery Dev call. Please add this as an agenda item in the meeting minutes if you would. :) |
Signed-off-by: Mohd Uzair <muzair.shaikh810@gmail.com>
Notes for Reviewers
This PR fixes #7952
Signed commits