filter Unit test #8111

Philip-21 · 2023-07-09T00:16:57Z

Notes for Reviewers

This PR fixes for issue #8087
It contains unit test for the filter.go in mesheryctl

Yes, I signed my commits.

Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>

welcome · 2023-07-09T00:16:59Z

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

github-actions · 2023-07-09T00:18:17Z

codecov · 2023-07-09T00:43:09Z

Codecov Report

Patch and project coverage have no change.

Comparison is base (2ed3712) 5.22% compared to head (c8f3a97) 5.22%.
Report is 4 commits behind head on master.

Additional details and impacted files

@@          Coverage Diff           @@
##           master   #8111   +/-   ##
======================================
  Coverage    5.22%   5.22%           
======================================
  Files         124     124           
  Lines       17522   17522           
======================================
  Hits          915     915           
  Misses      16435   16435           
  Partials      172     172

Flag	Coverage Δ
gointegrationtests	`5.22% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>

…reating response files Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>

Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>

Philip-21 · 2023-07-10T12:11:29Z

@leecalcote @alphaX86 @nebula-aac @hexxdump @abdullah1308
I followed the mesheryctl's plan of mocking unit test from this discussion.
The tests coverage keeps failing . The error is shown here , i'm still figuring out the error, but i am just giving you all a heads up on it ,i would also appreciate some help .

Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>

abdullah1308 · 2023-07-11T17:46:35Z

@Philip-21 Hey I have a PR making a few changes in mesheryctl filter here - #8063.

Once that is merged, make sure these tests still work.

Chadha93 · 2023-07-11T18:18:00Z

@Philip-21 Let's discuss this on the Meshery Dev call. Please add this as an agenda item in the meeting minutes if you would. :)

Philip-21 · 2023-07-12T07:26:21Z

@Philip-21 Hey I have a PR making a few changes in mesheryctl filter here - #8063.

Once that is merged, make sure these tests still work.

I've looked at the pr adding support for WASM filters is a great idea, it seems it will tackle the Error processing JSON response from server, because i also ran the other testcases locally, they failed and gave the same error .

…e directory Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>

Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>

Philip-21 · 2023-07-13T11:36:05Z

My Ci checks have passed on codecov with these latest commit, i added more testcases , I would like reviews on this before it gets merged

Philip-21 · 2023-07-14T06:49:56Z

@leecalcote ,@abdullah1308 , @Chadha93 👀👀👀

leecalcote · 2023-07-18T15:22:40Z

@abdullah1308 do you mind offering review here? 🙏

hexxdump · 2023-07-19T10:58:06Z

mesheryctl/internal/cli/root/filter/filter_test.go

+	}{
+		{
+			Name:             "filter viewcmd with name",
+			Args:             []string{"view", "view-filter-name"},


can we add tests to use filter viewcmd with valid name and some non-existing filtername?

hexxdump · 2023-07-19T10:58:30Z

mesheryctl/internal/cli/root/filter/filter_test.go

+		},
+		{
+			Name:             "filter viewcmd with ID",
+			Args:             []string{"view", "c0c6035a-b1b9-412d-aab2-4ed1f1d51f84"},


can we have a test for invalid ID as well?

Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>

hexxdump

LGTM

Philip-21 · 2023-07-22T16:06:23Z

@leecalcote everything is good with this Pr.

Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>

first commit

05c2f75

Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>

github-actions bot added the component/mesheryctl CLI for Meshery label Jul 9, 2023

Philip-21 changed the title ~~filter-test~~ filter Unit test Jul 9, 2023

Philip-21 self-assigned this Jul 9, 2023

Philip-21 added 3 commits July 9, 2023 11:37

adding id to fixture and directory

8e113fa

Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>

adding more features to view field, removing some files and fields, c…

e5c715b

…reating response files Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>

removing list field

602c567

Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>

adjusting id for the url and args fields

b35c612

Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>

Philip-21 added 2 commits July 12, 2023 19:57

adding more fields to filter test, adjusting the idents in the fixtur…

a98d0e1

…e directory Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>

adjusting fileds and testcases adding fixtures and response golden files

88f2dc1

Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>

leecalcote requested review from hexxdump and alphaX86 July 18, 2023 15:22

leecalcote requested review from abdullah1308 and removed request for alphaX86 July 18, 2023 15:22

hexxdump reviewed Jul 19, 2023

View reviewed changes

Philip-21 added 2 commits July 19, 2023 20:40

adding more fields for invalid inputs for viewcmd

a84309c

Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>

adding more golden files for invalid inputs for viewcmd

727d0c2

Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>

hexxdump previously approved these changes Jul 21, 2023

View reviewed changes

Merge branch 'master' into filter-test

f194402

changing user-ID outputs to 8 characters

c8f3a97

Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>

Philip-21 dismissed hexxdump’s stale review via c8f3a97 August 1, 2023 13:41

leecalcote merged commit f269378 into meshery:master Aug 5, 2023
16 of 18 checks passed

Philip-21 deleted the filter-test branch September 18, 2023 16:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

filter Unit test #8111

filter Unit test #8111

Philip-21 commented Jul 9, 2023 •

edited

welcome bot commented Jul 9, 2023

github-actions bot commented Jul 9, 2023 •

edited

codecov bot commented Jul 9, 2023 •

edited

Philip-21 commented Jul 10, 2023 •

edited

abdullah1308 commented Jul 11, 2023

Chadha93 commented Jul 11, 2023

Philip-21 commented Jul 12, 2023

Philip-21 commented Jul 13, 2023 •

edited

Philip-21 commented Jul 14, 2023

leecalcote commented Jul 18, 2023 •

edited

hexxdump Jul 19, 2023

Philip-21 Jul 19, 2023

hexxdump Jul 19, 2023

Philip-21 Jul 19, 2023

hexxdump left a comment

Philip-21 commented Jul 22, 2023

filter Unit test #8111

filter Unit test #8111

Conversation

Philip-21 commented Jul 9, 2023 • edited

welcome bot commented Jul 9, 2023

github-actions bot commented Jul 9, 2023 • edited

codecov bot commented Jul 9, 2023 • edited

Codecov Report

Philip-21 commented Jul 10, 2023 • edited

abdullah1308 commented Jul 11, 2023

Chadha93 commented Jul 11, 2023

Philip-21 commented Jul 12, 2023

Philip-21 commented Jul 13, 2023 • edited

Philip-21 commented Jul 14, 2023

leecalcote commented Jul 18, 2023 • edited

hexxdump Jul 19, 2023

Choose a reason for hiding this comment

Philip-21 Jul 19, 2023

Choose a reason for hiding this comment

hexxdump Jul 19, 2023

Choose a reason for hiding this comment

Philip-21 Jul 19, 2023

Choose a reason for hiding this comment

hexxdump left a comment

Choose a reason for hiding this comment

Philip-21 commented Jul 22, 2023

Philip-21 commented Jul 9, 2023 •

edited

github-actions bot commented Jul 9, 2023 •

edited

codecov bot commented Jul 9, 2023 •

edited

Philip-21 commented Jul 10, 2023 •

edited

Philip-21 commented Jul 13, 2023 •

edited

leecalcote commented Jul 18, 2023 •

edited