Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added grafana to playground cluster #8194

Closed
wants to merge 5 commits into from

Conversation

Freedisch
Copy link
Member

Notes for Reviewers

This PR fixes add Grafana to the playground cluster
mesh design: https://meshery.layer5.io/catalog/a459be4e-3945-4331-acf1-b9fec90846aa

PS: we need to verify if Prometheus and node exporter are still running in the playground cluster

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Freedisch <freeproduc@gmail.com>
Signed-off-by: Freedisch <freeproduc@gmail.com>
Signed-off-by: Freedisch <freeproduc@gmail.com>
@github-actions
Copy link

github-actions bot commented Jul 17, 2023

@Freedisch Freedisch changed the title Grafana map Added grafana to playground cluster Jul 17, 2023
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Freedisch, will you:

  1. confirm that you’re able to provision this infra in Playground (ns monitoring and grafana both present?)
  2. confirm that you’re able to update Meshery Server’s Settings to connect to that running instance of Grafana.

namespace: monitoring
annotations:
prometheus.io/scrape: 'true'
prometheus.io/port: '300'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prometheus will be exposed on 9090, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Freedisch ... following up.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it will be exposed at 9090

@leecalcote
Copy link
Member

@Freedisch what Grafana dashboards will be available in this Grafana deployment? We'll want a dashboard that is configured to collect the standard metrics available via Node Exporter.

@vishalvivekm
Copy link
Member

@Freedisch Let's discuss this on Meshery Dev call. Please add this as an agenda item in the meeting minutes if you would. :)

Freedisch and others added 2 commits July 19, 2023 22:56
Co-authored-by: Lee Calcote <leecalcote@gmail.com>
Signed-off-by: Thibaut F. BATALE <82499435+Freedisch@users.noreply.github.com>
Co-authored-by: Lee Calcote <leecalcote@gmail.com>
Signed-off-by: Thibaut F. BATALE <82499435+Freedisch@users.noreply.github.com>
@Freedisch
Copy link
Member Author

@leecalcote //

1- I’m able to provision the infra into the playground ✅
2- meshery's server cannot to Grafana, I believe this might be a network issue between my playground and Grafana 🚫 I'm still working on it
3- The charts that will provide Grafana are based on the metrics provided by Prometheus previously scraped from node exporter

Question: is the current deployment of Prometheus in the cluster accessible by Meshery's server? same question for node exporter?

@leecalcote
Copy link
Member

@Freedisch I've spoken to this a few times and walked through the Meshery Architecture slide on the Playground's deployment networking. Please refer to that slide. Rephrase your questions in context of that slide, if you have any after studying it.

@Freedisch
Copy link
Member Author

@Freedisch I've spoken to this a few times and walked through the Meshery Architecture slide on the Playground's deployment networking. Please refer to that slide. Rephrase your questions in the context of that slide, if you have any after studying it.

I meant, is there any way we could verify if the Prometheus deployment still running inside the cluster? if not we should redeploy it.

@leecalcote
Copy link
Member

When you open Visualizer mode, do you see it?

@Freedisch
Copy link
Member Author

When you open Visualizer mode, do you see it?

I Got it
I think we should have a documentation section for Prometheus setup into the playground

@stale
Copy link

stale bot commented Oct 13, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Oct 13, 2023
@stale
Copy link

stale bot commented Oct 24, 2023

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/stale Issue has not had any activity for an extended period of time playground
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants