-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
endpoints for user's keys #8267
Conversation
Signed-off-by: Freedisch <freeproduc@gmail.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #8267 +/- ##
=========================================
+ Coverage 5.17% 5.19% +0.02%
=========================================
Files 124 124
Lines 17771 17680 -91
=========================================
Hits 919 919
+ Misses 16680 16589 -91
Partials 172 172
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Freedisch <freeproduc@gmail.com>
@Freedisch Let's discuss this on the Meshery Dev call. Please add this as an agenda item in the meeting minutes if you would. :) |
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@Freedisch has this API endpoint been added to the "Meshery API Endpoints" spreadsheet? |
Signed-off-by: Freedisch <freeproduc@gmail.com>
@leecalcote, In the spreadsheet I saw a couple of endpoints that were not yet implemented like Would it be okay if I go ahead and implement them or it's not necessary |
Yes, as a separate PR in coordination with @abdullah1308, if you would, @Freedisch. |
@Freedisch can you paste a screenshot of the response ? |
@Freedisch we need this to land ASAP. It's blocking other work. |
@Freedisch Is the Meshery Cloud endpoint for keys paginated ? If it is, you need to add pagination here as well. |
No, it's not paginated |
Signed-off-by: Freedisch <freeproduc@gmail.com>
@abdullah1308, updated the docs |
I'm tying this off now... |
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
🚀 Preview for commit 1d677d0 at: https://64d8f4512fce3c2453194531--meshery-docs-preview.netlify.app |
Notes for Reviewers
This PR fixes #8227
Add endpoint for to retrieve keys from user
api/identity/users/keys
Signed commits