Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

endpoints for user's keys #8267

Merged
merged 10 commits into from
Aug 13, 2023
Merged

endpoints for user's keys #8267

merged 10 commits into from
Aug 13, 2023

Conversation

Freedisch
Copy link
Member

@Freedisch Freedisch commented Jul 25, 2023

Notes for Reviewers

This PR fixes #8227
Add endpoint for to retrieve keys from user
api/identity/users/keys

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Freedisch <freeproduc@gmail.com>
@github-actions
Copy link

github-actions bot commented Jul 25, 2023

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02% 🎉

Comparison is base (4e224bf) 5.17% compared to head (01ecd7b) 5.19%.
Report is 46 commits behind head on master.

❗ Current head 01ecd7b differs from pull request most recent head 1d677d0. Consider uploading reports for the commit 1d677d0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #8267      +/-   ##
=========================================
+ Coverage    5.17%   5.19%   +0.02%     
=========================================
  Files         124     124              
  Lines       17771   17680      -91     
=========================================
  Hits          919     919              
+ Misses      16680   16589      -91     
  Partials      172     172              
Flag Coverage Δ
e2etests ∅ <ø> (?)
gointegrationtests 5.19% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
server/handlers/user_handler.go 0.00% <0.00%> (ø)
server/router/server.go 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Freedisch <freeproduc@gmail.com>
@Chadha93
Copy link
Member

@Freedisch Let's discuss this on the Meshery Dev call. Please add this as an agenda item in the meeting minutes if you would. :)

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@leecalcote
Copy link
Member

@Freedisch has this API endpoint been added to the "Meshery API Endpoints" spreadsheet?

Signed-off-by: Freedisch <freeproduc@gmail.com>
@Freedisch
Copy link
Member Author

@leecalcote, In the spreadsheet I saw a couple of endpoints that were not yet implemented like
/api/meshmodel/<any-endpoint>?ver={version} to Filter resource by version
/api/meshmodels/models/{model}/components to Returns a list of registered components within model scope. and more...

Would it be okay if I go ahead and implement them or it's not necessary

@leecalcote
Copy link
Member

@leecalcote, In the spreadsheet I saw a couple of endpoints that were not yet implemented like /api/meshmodel/<any-endpoint>?ver={version} to Filter resource by version /api/meshmodels/models/{model}/components to Returns a list of registered components within model scope. and more...

Would it be okay if I go ahead and implement them or it's not necessary

Yes, as a separate PR in coordination with @abdullah1308, if you would, @Freedisch.

@abdullah1308
Copy link
Contributor

@Freedisch can you paste a screenshot of the response ?

server/handlers/user_handler.go Show resolved Hide resolved
server/handlers/user_handler.go Show resolved Hide resolved
@leecalcote
Copy link
Member

@Freedisch we need this to land ASAP. It's blocking other work.

@Freedisch
Copy link
Member Author

@abdullah1308,
image

@abdullah1308
Copy link
Contributor

@Freedisch Is the Meshery Cloud endpoint for keys paginated ? If it is, you need to add pagination here as well.

@Freedisch
Copy link
Member Author

@Freedisch Is the Meshery Cloud endpoint for keys paginated ? If it is, you need to add pagination here as well.

No, it's not paginated

Signed-off-by: Freedisch <freeproduc@gmail.com>
@Freedisch
Copy link
Member Author

@abdullah1308, updated the docs

@theBeginner86
Copy link
Member

I'm tying this off now...

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@github-actions github-actions bot added the area/docs Documentation update needed label Aug 13, 2023
@l5io
Copy link
Collaborator

l5io commented Aug 13, 2023

@theBeginner86 theBeginner86 merged commit 7f15677 into meshery:master Aug 13, 2023
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation update needed component/server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Server] - Endpoint to return keys mapped to a user
6 participants