-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MeshModel] Add new relationship definitions #8271
Conversation
Signed-off-by: Ananya Gautam <ananyagautam0607@gmail.com>
🚀 Preview for commit ccaae66 at: https://64bfa57719325c520c6195c4--meshery-docs-preview.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's define and agree upon the definition of a "Configurational" type and a kind "Peer". Neither of these two relationship kinds/subtypes are currently defined in MeshModal.
@@ -0,0 +1,65 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MUzairS15, please confirm whether these new relationship definitions will be automatically accounted for on Meshery Server boot. If they will, then @Boombag0607, further scrutiny is required. Define manual tests and show the outputs of your results; e.g.
❌ A ConfigMap of one Kubernetes version (e.g. v1.25.0) can relate to a Service within a different Kubernetes version (e.g. v1.27.1).
✅ A ConfigMap of one Kubernetes version (e.g. v1.25.0) can relate to a Service within a different Kubernetes version (e.g. v1.25.0).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leecalcote I'll take a look if these definitions will sit well. Or we can focus on getting the MeshModal relationship doc approved first, then code them in the server.
@Boombag0607 Let's discuss this on the Meshery Dev call. Please add this as an agenda item in the meeting minutes if you would. :) |
merge conflict |
Closing this. |
Notes for Reviewers
This PR adds Controller and Configurational peer relationship definitions.
Signed commits