Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MeshModel] Add new relationship definitions #8271

Closed
wants to merge 1 commit into from

Conversation

Boombag0607
Copy link
Member

Notes for Reviewers

This PR adds Controller and Configurational peer relationship definitions.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Ananya Gautam <ananyagautam0607@gmail.com>
@github-actions github-actions bot added area/docs Documentation update needed component/server labels Jul 25, 2023
@github-actions
Copy link

@l5io
Copy link
Collaborator

l5io commented Jul 25, 2023

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's define and agree upon the definition of a "Configurational" type and a kind "Peer". Neither of these two relationship kinds/subtypes are currently defined in MeshModal.

@@ -0,0 +1,65 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MUzairS15, please confirm whether these new relationship definitions will be automatically accounted for on Meshery Server boot. If they will, then @Boombag0607, further scrutiny is required. Define manual tests and show the outputs of your results; e.g.

❌ A ConfigMap of one Kubernetes version (e.g. v1.25.0) can relate to a Service within a different Kubernetes version (e.g. v1.27.1).
✅ A ConfigMap of one Kubernetes version (e.g. v1.25.0) can relate to a Service within a different Kubernetes version (e.g. v1.25.0).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leecalcote I'll take a look if these definitions will sit well. Or we can focus on getting the MeshModal relationship doc approved first, then code them in the server.

@Chadha93
Copy link
Member

@Boombag0607 Let's discuss this on the Meshery Dev call. Please add this as an agenda item in the meeting minutes if you would. :)

@leecalcote
Copy link
Member

merge conflict

@Boombag0607
Copy link
Member Author

Closing this.

@Boombag0607 Boombag0607 closed this Aug 1, 2023
@Boombag0607 Boombag0607 deleted the new-relation-2 branch August 1, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation update needed component/server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants