[ADDED] system model command

[zakisk]

Signed-off-by: Mohammed Zaki zs84907@gmail.com

Notes for Reviewers

This PR fixes #8176

Signed commits

• Yes, I signed my commits.
• Yes, I added unit tests.

[github-actions]

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2949e28) 10.11% compared to head (f1f2c41) 0.00%.
Report is 63 commits behind head on master.

❗ Current head f1f2c41 differs from pull request most recent head b3afb62. Consider uploading reports for the commit b3afb62 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #8284       +/-   ##
==========================================
- Coverage   10.11%       0   -10.12%     
==========================================
  Files         136       0      -136     
  Lines       21193       0    -21193     
==========================================
- Hits         2143       0     -2143     
+ Misses      18729       0    -18729     
+ Partials      321       0      -321     

Flag	Coverage Δ
unittests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[leecalcote]

@zakisk will you please see that each error code has a probable cause and a suggested remediation defined?

[zakisk]

@abdullah1308 as you can see in this PR that I've deleted mesheryctl/internal/cli/root/error.go file because I wanted to refernce them in mesheryctl/internal/cli/root/system package I was getting import cycle error and I was unable to reference them, and error functions in mesheryctl/internal/cli/root/error.go were only used by mesheryctl/internal/cli/root/version.go file so I copied all of them in mesheryctl/internal/cli/root/system/error.go file and chaged mesheryctl/internal/cli/root/version.go file.

[abdullah1308]

@zakisk The approach that me, @Philip-21 and @suhail34 have decided on is to move errors common to all mesheryctl commands to mesheryctl/pkg/utils/error.go. For errors that are specific to a sub-command they will be stored in the error.go file of sub-command's package.

There's 1/2 PRs up for making this change already. For now I suggest that you undo the change related to deleting the error.go file and moving the error codes. I understand that this causes the import cycle error. However once these other PRs are closed and if master is merged into this PR, these errors should be resolved. Hope this makes sense.

[zakisk]

@abdullah1308 error file that I've deleted was used by only one other file i.e version.go so I don't think that it is worth to undo deletion of that file. but if you still suggest me to do so I will add that error file in one more commit to this PR, is that you want?

[zakisk]

@abdullah1308 the approach I'm thinking of is that after your PR are merged we can remove all generic errors from mesheryctl in a new PR, does this sound good?

[abdullah1308]

@abdullah1308 error file that I've deleted was used by only one other file i.e version.go so I don't think that it is worth to undo deletion of that file. but if you still suggest me to do so I will add that error file in one more commit to this PR, is that you want?

@zakisk Yeah that is what I'd suggest for now.

[alphaX86]

@Freedisch the command you've suggested is adding new commit with the same message of old commit of which SHA key is passed it is not amending it on place.

If that's the case, then ignore the DCO for now. We'll take care of that later

[alphaX86]

You might need explanation for doing this here as this will be dynamic and change from time to time

[zakisk]

@alphaX86 API response is stored in golden file and the output will be same every time when tests run, in order to keep uniformity in tests pattern I did this because all other tests you can check in fliter or other commands are following this pattern,

[alphaX86]

@alphaX86 API response is stored in golden file and the output will be same every time when tests run, in order to keep uniformity in tests pattern I did this because all other tests you can check in fliter or other commands are following this pattern,

OK, you indeed need a token for them. I understand the requirement. But did you hardcode it?

[zakisk]

@alphaX86 yes

[alphaX86]

@alphaX86 yes

Is this token related to your Meshery Cloud account?

[zakisk]

@alphaX86 I've copied this from filter test its not mine.

[zakisk]

@alphaX86 and its more than two years old token.

[alphaX86]

@alphaX86 I've copied this from filter test its not mine.

Ok, noted 👍

[zakisk]

@alphaX86 @suhail34 @leecalcote @MUzairS15 is there anything else?

[zakisk]

@leecalcote @alphaX86 ??

[alphaX86]

@leecalcote @alphaX86 ??

I'll review this once I'm in my system

[zakisk]

@leecalcote @alphaX86 ??

I'll review this once I'm in my system

@alphaX86 have you done this?

[zakisk]

@leecalcote @alphaX86 it's been a while this PR is still open.

[leecalcote]

@MUzairS15, please review.

[leecalcote]

@zakisk great demo today. Thanks for taking everyone through your work. We’re all green 🚦 here.