-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: added docs for meshmodel #8291
Conversation
Signed-off-by: Yana-Gupta <yanagupta897@gmail.com>
Signed-off-by: Yana-Gupta <yanagupta897@gmail.com>
🚀 Preview for commit 8b5eea5 at: https://64c21c21c83715557503a8ae--meshery-docs-preview.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yana-Gupta Looks great! Nice work. (Just make sure you stay consistent with the spellings)
Thank you! I'll make sure to maintain consistency with the spellings. |
Signed-off-by: Yana-Gupta <yanagupta897@gmail.com>
🚀 Preview for commit 345ef2c at: https://64c240f1af01d46fb007dcea--meshery-docs-preview.netlify.app |
@thisiskaransgit and @Chadha93 would you review it once. |
Let's discuss it on the websites call. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Yana-Gupta, thanks for working on this 👍🏼 , some things for you to consider here would be
For Mehsmap:
- How to access the extension's UI should be explained once
- We have thoroughly described Mehsmap and how to use its features in the
/extensions
section. CTAs for the page should be included in the page. - Images in a queue do not look good
- Include the href of layer5.io pages for respective modes.
- Take reference from the websites pages and community resources to describe the steps
- Include current existing gifs, on the page if it describes the step better.
For Meshmodel page, include a short paragraph describing meshmodal summary
Signed-off-by: Yana-Gupta <yanagupta897@gmail.com>
🚀 Preview for commit 1014e74 at: https://64c7f375073d992f5aec7ac8--meshery-docs-preview.netlify.app |
🚀 Preview for commit e83011e at: https://64c7f6b79467062dbd58cccc--meshery-docs-preview.netlify.app |
@thisiskaransgit some test are failing. Could you please take a look about failing test and provide some insights or guidance. |
@Yana-Gupta Let's discuss this on Meshery Dev call. Please add this as an agenda item in the meeting minutes if you would. :) |
@Yana-Gupta, No worries, the Snapshot workflow failure is not related to the PR. |
Signed-off-by: Yana-Gupta <yanagupta897@gmail.com>
🚀 Preview for commit abd5870 at: https://64cca210842a6d600297c3e5--meshery-docs-preview.netlify.app |
@thisiskaransgit please review |
Signed-off-by: Yana-Gupta <yanagupta897@gmail.com>
🚀 Preview for commit e31190f at: https://64d1f541fc96e83dce4c69b1--meshery-docs-preview.netlify.app |
docs/pages/guides/meshmodel.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yana-Gupta, the request to update meshmodel page is still pending.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have written the summary about the MeshModel below the heading. Were you talking about it. Please see.
Signed-off-by: Yana-Gupta <yanagupta897@gmail.com>
🚀 Preview for commit 7d4dae4 at: https://64d3c5d9d41d05008f880999--meshery-docs-preview.netlify.app |
🚀 Preview for commit 639f410 at: https://64d3c72489a9ec073ebe5d39--meshery-docs-preview.netlify.app |
Signed-off-by: Yana-Gupta <yanagupta897@gmail.com>
Signed-off-by: Yana-Gupta <yanagupta897@gmail.com>
🚀 Preview for commit 3b505a0 at: https://64d65b2a0aeedc7cdee944b5--meshery-docs-preview.netlify.app |
🚀 Preview for commit 6781c3e at: https://64ddcdeb98c735538e08413b--meshery-docs-preview.netlify.app |
🚀 Preview for commit 3b505a0 at: https://64ddcf50822d0c4f482e990e--meshery-docs-preview.netlify.app |
…hips Signed-off-by: Yana-Gupta <yanagupta897@gmail.com>
🚀 Preview for commit 560e1ea at: https://64e4d44e55595f1f44ece3d0--meshery-docs-preview.netlify.app |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue. |
Notes for Reviewers
This PR fixes #8221
The pr fixed point 1 and 4 mentioned in the issue.
Signed commits