Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added docs for meshmodel #8291

Closed
wants to merge 12 commits into from
Closed

docs: added docs for meshmodel #8291

wants to merge 12 commits into from

Conversation

Yana-Gupta
Copy link
Member

@Yana-Gupta Yana-Gupta commented Jul 27, 2023

Notes for Reviewers

This PR fixes #8221
The pr fixed point 1 and 4 mentioned in the issue.

Signed commits

  • Yes, I signed my commits.

@github-actions github-actions bot added the area/docs Documentation update needed label Jul 27, 2023
Signed-off-by: Yana-Gupta <yanagupta897@gmail.com>
Signed-off-by: Yana-Gupta <yanagupta897@gmail.com>
@github-actions
Copy link

github-actions bot commented Jul 27, 2023

@Yana-Gupta Yana-Gupta changed the title Docs meshmodel docs: added docs for meshmodel Jul 27, 2023
@l5io
Copy link
Collaborator

l5io commented Jul 27, 2023

Copy link
Member

@Boombag0607 Boombag0607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yana-Gupta Looks great! Nice work. (Just make sure you stay consistent with the spellings)

@Yana-Gupta
Copy link
Member Author

@Yana-Gupta Looks great! Nice work. (Just make sure you stay consistent with the spellings)

Thank you! I'll make sure to maintain consistency with the spellings.

Signed-off-by: Yana-Gupta <yanagupta897@gmail.com>
@l5io
Copy link
Collaborator

l5io commented Jul 27, 2023

@Yana-Gupta
Copy link
Member Author

@thisiskaransgit and @Chadha93 would you review it once.

@sudhanshutech
Copy link
Member

Let's discuss it on the websites call.
Please add this as an agenda item in the meeting minutes, if you would :)

https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit#heading=h.lohhtewfwima

Copy link
Contributor

@thisiskaransgit thisiskaransgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Yana-Gupta, thanks for working on this 👍🏼 , some things for you to consider here would be
For Mehsmap:

  • How to access the extension's UI should be explained once
  • We have thoroughly described Mehsmap and how to use its features in the /extensions section. CTAs for the page should be included in the page.
  • Images in a queue do not look good
  1. Include the href of layer5.io pages for respective modes.
  2. Take reference from the websites pages and community resources to describe the steps
  3. Include current existing gifs, on the page if it describes the step better.

For Meshmodel page, include a short paragraph describing meshmodal summary

Signed-off-by: Yana-Gupta <yanagupta897@gmail.com>
@l5io
Copy link
Collaborator

l5io commented Jul 31, 2023

@l5io
Copy link
Collaborator

l5io commented Jul 31, 2023

@Yana-Gupta
Copy link
Member Author

Yana-Gupta commented Aug 2, 2023

@thisiskaransgit some test are failing. Could you please take a look about failing test and provide some insights or guidance.

@vishalvivekm
Copy link
Member

@Yana-Gupta Let's discuss this on Meshery Dev call. Please add this as an agenda item in the meeting minutes if you would. :)

@thisiskaransgit
Copy link
Contributor

thisiskaransgit commented Aug 3, 2023

@Yana-Gupta, No worries, the Snapshot workflow failure is not related to the PR.

Signed-off-by: Yana-Gupta <yanagupta897@gmail.com>
@l5io
Copy link
Collaborator

l5io commented Aug 4, 2023

@Yana-Gupta
Copy link
Member Author

@thisiskaransgit please review

Signed-off-by: Yana-Gupta <yanagupta897@gmail.com>
@l5io
Copy link
Collaborator

l5io commented Aug 8, 2023

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yana-Gupta, the request to update meshmodel page is still pending.

Copy link
Member Author

@Yana-Gupta Yana-Gupta Aug 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thisiskaransgit
image

I have written the summary about the MeshModel below the heading. Were you talking about it. Please see.

Signed-off-by: Yana-Gupta <yanagupta897@gmail.com>
@l5io
Copy link
Collaborator

l5io commented Aug 9, 2023

@l5io
Copy link
Collaborator

l5io commented Aug 9, 2023

Signed-off-by: Yana-Gupta <yanagupta897@gmail.com>
Signed-off-by: Yana-Gupta <yanagupta897@gmail.com>
@l5io
Copy link
Collaborator

l5io commented Aug 11, 2023

@l5io
Copy link
Collaborator

l5io commented Aug 17, 2023

@l5io
Copy link
Collaborator

l5io commented Aug 17, 2023

…hips

Signed-off-by: Yana-Gupta <yanagupta897@gmail.com>
@l5io
Copy link
Collaborator

l5io commented Aug 22, 2023

@Yana-Gupta Yana-Gupta marked this pull request as draft September 2, 2023 16:59
@leecalcote leecalcote removed the request for review from Chadha93 September 30, 2023 15:14
Copy link

stale bot commented Nov 10, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Nov 10, 2023
Copy link

stale bot commented Nov 20, 2023

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation update needed issue/stale Issue has not had any activity for an extended period of time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] MeshModel User Guides
6 participants