Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Update Meshery Helm Chart #8355

Merged
merged 8 commits into from
Aug 2, 2023
Merged

[CI] Update Meshery Helm Chart #8355

merged 8 commits into from
Aug 2, 2023

Conversation

theBeginner86
Copy link
Member

@theBeginner86 theBeginner86 commented Aug 2, 2023 •
edited

Notes for Reviewers

This PR:

  • Fixes a bug where correct namespace from metadata in values.yaml was not being used leading to failed Meshery deployment using Helm.
  • Ensure Meshery Adapters for Service Meshes are not pre-installed
  • Updated README.md

This PR fixes #

Signed commits

  • Yes, I signed my commits.

@theBeginner86
fix missing use of ns from metadata
5cc3702 
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@github-actions github-actions bot added the framework/helm Issues related to helm-charts label Aug 2, 2023
@github-actions
Copy link

github-actions bot commented Aug 2, 2023 •
edited

@theBeginner86 theBeginner86 added the kind/bug Something isn't working label Aug 2, 2023
@theBeginner86
disable all adapters by default
4ee4734 
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@theBeginner86
metadata namespace is propagated to subcharts of adapters
6ffa330 
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@theBeginner86
fix dependencies + regenerate Chart.lock
43545e7 
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@theBeginner86
fix missing propogation of meshery ns from medata
d22d0e8 
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@theBeginner86
rm requirements from README.md
053e1d5 
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@theBeginner86
add more readme for custom installation
894afcb 
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@theBeginner86
Merge branch 'master' into theBeginner86/chore/16
b3053e4
@leecalcote
Copy link
Member

💪

@leecalcote leecalcote merged commit c952803 into meshery:master Aug 2, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leecalcote leecalcote leecalcote approved these changes

Assignees
No one assigned
Labels
area/devops framework/helm Issues related to helm-charts kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@theBeginner86 @leecalcote