Add endpoint for all connections #8356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: abdullah1308 <abdullahrafi.1308@gmail.com>
|
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #8356 +/- ##
=========================================
- Coverage 5.20% 5.20% -0.01%
=========================================
Files 124 124
Lines 17628 17664 +36
=========================================
+ Hits 918 919 +1
- Misses 16538 16573 +35
Partials 172 172
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
MUzairS15
reviewed
Aug 2, 2023
| @@ -39,7 +39,7 @@ type Connection struct { | |||
|
|
|||
| // swagger:response ConnectionPage | |||
| type ConnectionPage struct { | |||
| Connection []Connection `json:"connection"` | |||
| Connections []Connection `json:"connections"` | |||
There was a problem hiding this comment.
@abdullah1308 This will also require changes in UI, right?
There was a problem hiding this comment.
@MUzairS15 These endpoints aren't being used anywhere.
MUzairS15
previously approved these changes
Aug 2, 2023
|
Merge conflict.. |
|
Spreadsheet updated? |
|
@senali-d is this what you need? |
Signed-off-by: abdullah1308 <abdullahrafi.1308@gmail.com>
|
Fixed merge conflict |
Yes I'm waiting for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #
Added GET
/api/integrations/connectionsSigned commits