fix: test for delete filter command

[Yana-Gupta]

Notes for Reviewers

This PR fixes failing test in delete_test.go

Signed commits

• Yes, I signed my commits.

[github-actions]

[Yana-Gupta]

@theBeginner86

[leecalcote]

Gosh, I can't quite tell what the change is here...

[Yana-Gupta]

Gosh, I can't quite tell what the change is here...

Added space empty space \n to match both expected and actual responses, the actual response contains space at end but the expected doesn't so, by adding an empty single line at the end of those expected responses from delete.kuma.output.golden and delete.rollout.output.golden from where those strings(expected response) are coming the test cases will get passed.

[Philip-21]

@Yana-Gupta with or without these spaces the testcase still passes

[Yana-Gupta]

some tests are failing here

[zakisk]

@Yana-Gupta are copying the output from the terminal to the golden file?

[zakisk]

@Yana-Gupta if so then copying output from terminal to the golden file doesn't copy the exact output generated by CLI. in order to get exact output in golden file use output operator > in terminal do this, (assuming you're in meshery/mesheryctl/ directory) ./mesheryctl filter delete c0c6035a-b1b9-412d-aab2-4ed1f1d51f84 Kuma-Test > ./internal/cli/root/filter/fixtures/delete.kuma.output.golden. it will store the exact output in the output golden file.

[Yana-Gupta]

@Yana-Gupta if so then copying output from terminal to the golden file doesn't copy the exact output generated by CLI. in order to get exact output in golden file use output operator > in terminal do this, (assuming you're in meshery/mesheryctl/ directory) ./mesheryctl filter delete c0c6035a-b1b9-412d-aab2-4ed1f1d51f84 Kuma-Test > ./internal/cli/root/filter/fixtures/delete.kuma.output.golden. it will store the exact output in the output golden file.

@zakisk Thanks for informing

[leecalcote]

I still don't see a difference... what was changed here?

[leecalcote]

@Yana-Gupta what did you change in this PR from what is in master?

[Yana-Gupta]

@Yana-Gupta what did you change in this PR from what is in master?

only an empty line difference was changed, before it was not there in master I just added it.

[vishalvivekm]

@Yana-Gupta Let's discuss this on Meshery Dev call. Please add this as an agenda item in the meeting minutes if you would. :)

[Yana-Gupta]

@Yana-Gupta Let's discuss this on Meshery Dev call. Please add this as an agenda item in the meeting minutes if you would. :)

Thanks @vishalvivekm it was already discussed earlier on Meshery build and release call.

[leecalcote]

@Yana-Gupta what did you change in this PR from what is in master?

only an empty line difference was changed, before it was not there in master I just added it.

Sounds real good. Or do you mean that you removed an extraneous line return?

[Philip-21]

@Yana-Gupta Thanks i see what you meant by this indent you made. The test passed with the additional changes i made

[Yana-Gupta]

@Yana-Gupta what did you change in this PR from what is in master?

only an empty line difference was changed, before it was not there in master I just added it.

Sounds real good. Or do you mean that you removed an extraneous line return?

I adjusted the lines to pass the test case.. but I have added space to pass the testcase in the testdata files.. I don't know why the changes are not same as of my local system

[Philip-21]

@Yana-Gupta what did you change in this PR from what is in master?

only an empty line difference was changed, before it was not there in master I just added it.

Sounds real good. Or do you mean that you removed an extraneous line return?

I adjusted the lines to pass the test case.. but I have added space to pass the testcase in the testdata files.. I don't know why the changes are not same as of my local system

I was able to sort that out in this pr, but other changes are still ongoing in it

[Philip-21]

@Yana-Gupta when working with text files or string data that might be used across different systems, newline representations are used in a specific context, newline representations can lead to compatibility issues, especially when comparing or processing texts across platforms.
Windows uses /r/n while Unix is /n so there can be compatibility issues.
It's why the changes you made were not effective at first