Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] MeshKit Error Util: duplicate errors causing failures #8402

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

suhail34
Copy link
Contributor

@suhail34 suhail34 commented Aug 7, 2023

Notes for Reviewers

This PR fixes #6352

Signed commits

  • Yes, I signed my commits.

Signed-off-by: suhail34 <suhailkna@gmail.com>
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (c1df7db) 5.20% compared to head (7392f2c) 5.20%.
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #8402      +/-   ##
=========================================
- Coverage    5.20%   5.20%   -0.01%     
=========================================
  Files         124     124              
  Lines       17663   17664       +1     
=========================================
  Hits          919     919              
- Misses      16572   16573       +1     
  Partials      172     172              
Flag Coverage Δ
gointegrationtests 5.20% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
mesheryctl/internal/cli/root/version.go 34.18% <0.00%> (ø)
server/cmd/error.go 0.00% <ø> (ø)
server/handlers/connections_handlers.go 0.00% <0.00%> (ø)
server/handlers/contexts_handler.go 0.00% <0.00%> (ø)
server/handlers/error.go 0.00% <0.00%> (ø)
server/handlers/events_streamer.go 0.00% <0.00%> (ø)
server/handlers/extensions.go 0.00% <0.00%> (ø)
server/handlers/fetch_results_handler.go 0.00% <0.00%> (ø)
server/handlers/grafana_handlers.go 1.14% <0.00%> (ø)
server/handlers/k8sconfig_handler.go 2.08% <0.00%> (ø)
... and 16 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leecalcote leecalcote requested review from zakisk and nebula-aac and removed request for leecalcote August 8, 2023 19:22
Signed-off-by: suhail34 <suhailkna@gmail.com>
@suhail34
Copy link
Contributor Author

suhail34 commented Aug 8, 2023

Please Don't merge until i create a precommit hook and a workflow to run make error so that no duplicacy again happens

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @suhail34 👏

@leecalcote leecalcote merged commit dc457e5 into meshery:master Aug 10, 2023
22 of 24 checks passed
@suhail34 suhail34 deleted the chore/suhail34/6352 branch August 11, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] MeshKit Error Util: duplicate errors causing failures
2 participants