modifications for codecov report to generate

[ash-kamrip]

Notes for Reviewers

This PR fixes #7805

Hi , I've tried to update some of the golden files and commented out a few tests that needs modification , this PR should fix the current unit tests so that we can get updated code coverage.

P.S i am not able to fix any of the integration test so those will def fail

Signed commits

• Yes, I signed my commits.

[github-actions]

[welcome]

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while performing a commit.

[l5io]

🚀 Preview for commit 4934d78 at: https://64dbb45544a2fb0986d358d6--meshery-docs-preview.netlify.app

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: +5.47% 🎉

Comparison is base (4e224bf) 5.17% compared to head (da23dd5) 10.64%.
Report is 167 commits behind head on master.

❗ Current head da23dd5 differs from pull request most recent head 318648b. Consider uploading reports for the commit 318648b to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8478      +/-   ##
==========================================
+ Coverage    5.17%   10.64%   +5.47%     
==========================================
  Files         124      124              
  Lines       17771    17920     +149     
==========================================
+ Hits          919     1907     +988     
+ Misses      16680    15701     -979     
- Partials      172      312     +140     

Flag	Coverage Δ
gointegrationtests	?
unittests	10.64% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
mesheryctl/internal/cli/root/filter/delete.go	43.24% <ø> (+43.24%)	⬆️
server/handlers/component_handler.go	0.00% <0.00%> (ø)
server/handlers/connections_handlers.go	0.00% <0.00%> (ø)
server/handlers/error.go	0.00% <0.00%> (ø)
server/handlers/mesh_ops_handlers.go	0.74% <0.00%> (-0.01%)	⬇️
server/handlers/relationship_handlers.go	0.00% <0.00%> (ø)
server/handlers/user_handler.go	0.00% <0.00%> (ø)
server/helpers/adapters_tracker.go	0.00% <0.00%> (ø)
server/meshes/meshops.pb.go	2.96% <0.00%> (-0.03%)	⬇️
server/meshes/meshops_grpc.pb.go	0.00% <0.00%> (ø)
... and 1 more

... and 48 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[l5io]

🚀 Preview for commit 318648b at: https://64dbba918254031268fd590b--meshery-docs-preview.netlify.app

[l5io]

🚀 Preview for commit c8370e0 at: https://64dbdae35df0102d5e60f4c9--meshery-docs-preview.netlify.app

[Philip-21]

@ash-kamrip alot of changes here, the code coverage rate currently seems to increase to 19%
also when you ran these test that you changed how were you able to make these outputs generated , from the golden files most of the outputs are not generated you removed them

[Philip-21]

@ash-kamrip i have dropped some comments here , please you can give a brief description of what you implemented so we can know where we are headed at. Incase I want to work on some other unit tests I want to follow your approach but i need to understand why certain things were implemented

[Philip-21]

there seems to be an issue with the Error codes please check it out

[Philip-21]

@ash-kamrip the integration tests are failing

[vishalvivekm]

@ash-kamrip Let's discuss this on Meshery Dev call. Please add this as an agenda item in the meeting minutes if you would. :)

[l5io]

🚀 Preview for commit c8370e0 at: https://64dced139f7e46298dc3b8d7--meshery-docs-preview.netlify.app

[l5io]

🚀 Preview for commit 6d40ef4 at: https://64dcf92fe7aa1d0488bf9091--meshery-docs-preview.netlify.app

[l5io]

🚀 Preview for commit da23dd5 at: https://64dcfa4cf2b35106f55488cb--meshery-docs-preview.netlify.app

[suhail34]

It would be great if we can focus more on how to make failing test pass rather than just making failing workflow to pass

[suhail34]

Please remove the changes you made to error-code-updates.yaml it isn't needed as it is not a private repo that it would require github access token to checkout

[ash-kamrip]

Oopsies will remove them ! my bad wanted to commit to the other branch

[l5io]

🚀 Preview for commit 4550228 at: https://64dd0eafa975f20e3a81d849--meshery-docs-preview.netlify.app

[l5io]

🚀 Preview for commit 318648b at: https://64dd16b5e4ec051608da3fd6--meshery-docs-preview.netlify.app

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.