Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Enhance Notification Center #8483

Merged

Conversation

aabidsofi19
Copy link
Contributor

@aabidsofi19 aabidsofi19 commented Aug 16, 2023

Notes for Reviewers

Related to #8485

This Pr Adds the following :

  • Custom Snackbar hook to enable sending toaster messages in notification center
  • timestamp for events
  • deeplink from toasts
  • Refactored Applications Pages and Designs Page to use these new notifications for toasts
notificationcenter-2023-08-16_16.48.07.mp4

Signed commits

  • Yes, I signed my commits.

@github-actions github-actions bot added the component/ui User Interface label Aug 16, 2023
@aabidsofi19
Copy link
Contributor Author

aabidsofi19 commented Aug 16, 2023

Next Steps :

  • start using these new notifications in all other places ( simple copy pasta work )
  • support for Class Based Components ( on it )

@github-actions
Copy link

github-actions bot commented Aug 16, 2023

Signed-off-by: aabidsofi19 <mailtoaabid01@gmail.com>
Signed-off-by: aabidsofi19 <mailtoaabid01@gmail.com>
Signed-off-by: aabidsofi19 <mailtoaabid01@gmail.com>
Signed-off-by: aabidsofi19 <mailtoaabid01@gmail.com>
Signed-off-by: aabidsofi19 <mailtoaabid01@gmail.com>
@aabidsofi19 aabidsofi19 added the pr/draft WIP/Draft pull request label Aug 16, 2023
Copy link
Contributor

@Yashsharma1911 Yashsharma1911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aabidsofi19 I wonder if we can use hook similar that we have in meshery cloud with customization so that we will be consistent on both side thoughts?

Signed-off-by: aabidsofi19 <mailtoaabid01@gmail.com>
Signed-off-by: aabidsofi19 <mailtoaabid01@gmail.com>
@aabidsofi19
Copy link
Contributor Author

aabidsofi19 commented Aug 16, 2023

Notes :

  • Added Support for Class Based Components , we can use the custom withNotify HOC to pass notify as a prop in CBC and then use it as normal
  • Making the whole snackbar clickable causes memory leaks . it is a issue with the version of snackbar we are using , but these simple abstractions we can easily upgrade it when we move to mui5 and react 18

Signed-off-by: aabidsofi19 <mailtoaabid01@gmail.com>
@aabidsofi19
Copy link
Contributor Author

@aabidsofi19 I wonder if we can use hook similar that we have in meshery cloud with customization so that we will be consistent on both side thoughts?

We need to support sse and classbased components also

@aabidsofi19 aabidsofi19 removed the pr/draft WIP/Draft pull request label Aug 16, 2023
@leecalcote
Copy link
Member

Notes :

  • Added Support for Class Based Components , we can use the custom withNotify HOC to pass notify as a prop in CBC and then use it as normal
  • Making the whole snackbar clickable causes memory leaks . it is a issue with the version of snackbar we are using , but these simple abstractions we can easily upgrade it when we move to mui5 and react 18

Great explanation.

@leecalcote leecalcote merged commit 8f96f49 into meshery:master Aug 16, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants