Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Send toaster informational notification upon save of design #8486

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

Chadha93
Copy link
Member

Notes for Reviewers
Send toaster informational notification upon saving of design

This PR fixes #8465

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Gaurav Chadha <gauravchadha1676@gmail.com>
@github-actions github-actions bot added the component/ui User Interface label Aug 16, 2023
@github-actions
Copy link

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Can we get this pushed into the Notification Center as well?

Let's get instructions on how to do this into the Contributing UI guide. // @sudhanshutech @aabidsofi19

@Abhishek-kumar09 we could use your help in understanding this mechanism, if you have time.

@aabidsofi19
Copy link
Contributor

@Chadha93 i just finished implementing support for sending toast messages into notificationcenter . i will talk about it in detail after the meeting :)

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A follow up PR to use the Notification Center and new snackbar approach is needed.

@leecalcote leecalcote merged commit 7b9c084 into meshery:master Aug 16, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Designs: Send toaster informational notification upon save of design.
3 participants