Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added wrapper function for json parsing #8556

Closed
wants to merge 5 commits into from
Closed

added wrapper function for json parsing #8556

wants to merge 5 commits into from

Conversation

EraKin575
Copy link
Contributor

@EraKin575 EraKin575 commented Aug 21, 2023 •
edited

Notes for Reviewers

This PR fixes #8496

Added a wrapper function for json parsing

Signed commits

  • Yes, I signed my commits.

@github-actions github-actions bot added area/docs Documentation update needed component/ui User Interface component/extensions Issues related to extension points labels Aug 21, 2023
@github-actions
Copy link

github-actions bot commented Aug 21, 2023 •
edited

@l5io
Copy link
Collaborator

l5io commented Aug 21, 2023

🚀 Preview for commit 00eeb6b at: https://64e31b7b7de90c60886c42f1--meshery-docs-preview.netlify.app

leecalcote
leecalcote requested changes Aug 22, 2023
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Don't change older versions of the docs. Those snapshots are frozen in time.
  2. Don't intermix json.parse for docs (not part of the original request) with the originally requested Meshery UI changes.

@EraKin575
Copy link
Contributor Author

@leecalcote so I have to wrap every JSON.parse except the docs, right?

@leecalcote
Copy link
Member

@leecalcote so I have to wrap every JSON.parse except the docs, right?

@EraKin575 you have to execute on the original request by making changes to Meshery UI.

@l5io
Copy link
Collaborator

l5io commented Aug 22, 2023

🚀 Preview for commit 2e9e30b at: https://64e49194dafe34027b6e5472--meshery-docs-preview.netlify.app

leecalcote
leecalcote requested changes Aug 22, 2023
View reviewed changes
docs/assets/js/lightbox.js Outdated
@@ -1,3 +1,5 @@
import jsonParse from "../../../ui/components/ConnectionWizard/helpers/parseJson";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No docs updates requested.

@vishalvivekm
Copy link
Member

@EraKin575 Let's discuss this on Meshery Dev call. Please add this as an agenda item in the meeting minutes if you would. :)

@EraKin575
Copy link
Contributor Author

sure thing @vishalvivekm

@EraKin575 EraKin575 closed this Aug 23, 2023
@EraKin575 EraKin575 reopened this Aug 23, 2023
@github-actions github-actions bot removed area/docs Documentation update needed labels Aug 23, 2023
aabidsofi19
aabidsofi19 requested changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@aabidsofi19 aabidsofi19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EraKin575 rename this to safeJsonParse and add jsDoc comments . then we are good to merge

@leecalcote
Copy link
Member

@EraKin575 merge conflict...

@EraKin575 EraKin575 closed this Sep 9, 2023
@EraKin575 EraKin575 reopened this Sep 9, 2023
@github-actions github-actions bot added the area/docs Documentation update needed label Sep 9, 2023
@l5io
Copy link
Collaborator

l5io commented Sep 9, 2023

🚀 Preview for commit efd06ba at: https://64fcba2f130f941068f25ddf--meshery-docs-preview.netlify.app

@l5io
Copy link
Collaborator

l5io commented Sep 10, 2023

🚀 Preview for commit fc508db at: https://64fd8f6bfa00dc0452fbc0af--meshery-docs-preview.netlify.app

@EraKin575
Copy link
Contributor Author

@aabidsofi19

@l5io
Copy link
Collaborator

l5io commented Sep 14, 2023

🚀 Preview for commit 9a5c41e at: https://6502c3245cd4a732161e7251--meshery-docs-preview.netlify.app

@sudhanshutech
Copy link
Member

sudhanshutech commented Sep 16, 2023 •
edited

@EraKin575 there is still docs changes which is not needed, revert any change made to docs then we are good to go

@l5io
Copy link
Collaborator

l5io commented Sep 17, 2023

🚀 Preview for commit d9b11d4 at: https://6506b49b0c4f2c173f04bda9--meshery-docs-preview.netlify.app

@l5io
Copy link
Collaborator

l5io commented Sep 17, 2023

🚀 Preview for commit 0ce4909 at: https://6506b57c30d1f517158a9d19--meshery-docs-preview.netlify.app

@EraKin575
removed unnecessary spaces
b13aeb3 
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
@l5io
Copy link
Collaborator

l5io commented Sep 17, 2023

🚀 Preview for commit b13aeb3 at: https://6506c49dfbb37b1e97cf0b5d--meshery-docs-preview.netlify.app

@stale
Copy link

stale bot commented Oct 28, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Oct 28, 2023
@stale Stale
Copy link

stale bot commented Nov 7, 2023

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leecalcote leecalcote Awaiting requested review from leecalcote

@MUzairS15 MUzairS15 Awaiting requested review from MUzairS15

@aabidsofi19 aabidsofi19 Awaiting requested review from aabidsofi19

Assignees
No one assigned
Labels
area/docs Documentation update needed component/extensions Issues related to extension points component/ui User Interface issue/stale Issue has not had any activity for an extended period of time
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add wrapper around JSON.parse
6 participants
@EraKin575 @l5io @leecalcote @vishalvivekm @sudhanshutech @aabidsofi19