Email will not be sent without any failure

[VaibhavMalik4187]

Removed extra string: EMAIL_BODY= from the environment variable EMAIL_BODY.

Fixes: #8664

Signed commits

• Yes, I signed my commits.

[Ghat0tkach]

@VaibhavMalik4187 Let's discuss this on Meshery Dev call. Please add this as an agenda item in the meeting minutes if you would. :)

[suhail34]

meshery/.github/workflows/build-and-release-stable.yml

Line 194 in 56eb7b7

if: ${{ always() }}

I think the problem is here the condition should be something like this
if: ${ always() && (needs.update-grapql-docs.result == 'failure' || needs.update-swagger-docs.result=='failure'and so on for other jobs) }

[VaibhavMalik4187]

meshery/.github/workflows/build-and-release-stable.yml

Line 194 in 56eb7b7

if: ${{ always() }}

I think the problem is here the condition should be something like this
if: ${ always() && (needs.update-grapql-docs.result == 'failure' || needs.update-swagger-docs.result=='failure'and so on for other jobs) }

This is yet another way to check if we should start the job or not. However, this looks very tedious, especially for workflows having multiple jobs.
Do you mind if I ask what is wrong with:

      - name: Send Email Notification
        if: ${{ env.EMAIL_BODY != '' }}

[suhail34]

Okay i got you now we can do that but if there are no jobs failed then why do we need to run email-on-failure we can stop it the start itself

[VaibhavMalik4187]

Okay i got you now we can do that but if there are no jobs failed then why do we need to run email-on-failure we can stop it the start itself

Your approach suggests checking for failed jobs by hard coding the values and then comparing the result of each job with "failure". This violates the DRY principle. It is also prone to error. Suppose, later, at some point, 5 more jobs are added in this workflow. The comparisons would keep on growing. That's why I'm using the REST API to determine the failed jobs without hardcoding any values. And just as you suggested, I'm also skipping the Send email step if none of the jobs have failed.

[suhail34]

Yes you are right that was just a suggestion what i meant was to check if there was a failure in any of the previously runned job then only email-on-failure job should run we can also try
if: failure() so that it will run only on failure of previously runned job

[VaibhavMalik4187]

Yes you are right that was just a suggestion what i meant was to check if there was a failure in any of the previously runned job then only email-on-failure job should run we can also try if: failure() so that it will run only on failure of previously runned job

Great suggestion, I've changed the code accordingly.

[suhail34]

LGTM 👌