converted class based dashboard component to functional component #8724
Conversation
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
EraKin575
changed the title
|
@aabidsofi19 please have a look |
|
@EraKin575 |
|
. @EraKin575 but this pr also some of the same issues as in #8701 (review) . take a look |
|
@Rajdip019 thanks! |
|
@aabidsofi19 a lot of functions are unused as well as some states. Is it okay to just comment them out? |
Yes, you can clean them up. That's the best way. |
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
|
@Rajdip019 @EraKin575 are all changes incorporated here? |
Yes |
| // searchable : true, | ||
| // setCellProps : () => ({ style : { textAlign : "center" } }), | ||
| // customHeadRender : ({ index, ...column }, sortColumn) => { | ||
| // return ( |
There was a problem hiding this comment.
why so much commented out code, are these have no use?
There was a problem hiding this comment.
if not then give description why they are commented
There was a problem hiding this comment.
these functions weren't used anywhere in the component. That's why I commented them
There was a problem hiding this comment.
@sudhanshutech these were functions that were there before I changed to functional component. I thought these functions would be used later with a newer version. So, I just commented these out and removed the pieces of code that were converted
|
@EraKin575 will you provide a recording after making a build that all works fine since there are lot of changes |
|
@sudhanshutech working as expected :) simplescreenrecorder-2023-09-18_13.06.00.mp4 |
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
|
@aabidsofi19 please merge this if this looks good to do so |
Notes for Reviewers
This PR fixes #8613
changed class based component to functional
Signed commits