Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meshmodel Postgres & Kubernetes Component #8767

Merged
merged 4 commits into from Nov 24, 2023
Merged

Conversation

ptdatta
Copy link
Contributor

@ptdatta ptdatta commented Sep 14, 2023

Notes for Reviewers

This PR fixes
#8758
#8757

  • For the Kubernetes icon we can use Cytoscape round-heptagon shape.
  • For the Postgres icon we can use Cytoscape vee or reverse round-triangle shape.

Signed commits

  • Yes, I signed my commits.

@welcome
Copy link

welcome bot commented Sep 14, 2023

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while performing a commit.

@ritiksaxena124
Copy link
Contributor

ritiksaxena124 commented Sep 15, 2023

The icon needs to be created of component, not of model Postgres and Kubernetes are models. So you will have to create an Icon for the Postgres Cluster and Kubernetes Endpoints.
BTW, thanks for taking these up @ptdatta 😉 you are doing great 🙌

@ptdatta
Copy link
Contributor Author

ptdatta commented Sep 15, 2023

Thanks @ritiksaxena124, does I have to create something like:
image
for Postgres and
image
for Kubernetes ???

@csengineer1990
Copy link
Contributor

csengineer1990 commented Sep 17, 2023

Thanks @ritiksaxena124, does I have to create something like: image for Postgres and image for Kubernetes ???

@ptdatta could you please tell me which tool are using to create icons? Acceptable tool icons? I also want to contribute.

@saurabh100ni
Copy link
Contributor

Let's discuss this on the Meshery dev call tomorrow,
Please add this as your agenda item in Docs: https://docs.google.com/document/d/1Dg4Uz9rGTuGHmYZwIt47z1j5x3LmnpxD1M1SgypAkQ0/edit

Signed-off-by: Parthib <parthibdutta02@gmail.com>
Signed-off-by: Parthib <parthibdutta02@gmail.com>
Signed-off-by: Parthib <parthibdutta02@gmail.com>
@ptdatta
Copy link
Contributor Author

ptdatta commented Sep 29, 2023

@ritiksaxena124 Is it now correct?

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, @ptdatta. 👍

@@ -0,0 +1,17 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ptdatta are you going to finish this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it's already completed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ptdatta you thing that you have removed this file?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please deliver colored and white versions of just the icons and not the shapes.

Note, that we already have the Postgres elephant, so, you'll need to bring something else.

Copy link

stale bot commented Nov 24, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added issue/stale Issue has not had any activity for an extended period of time and removed issue/stale Issue has not had any activity for an extended period of time labels Nov 24, 2023
@leecalcote leecalcote merged commit e249e19 into meshery:master Nov 24, 2023
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants