New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meshmodel Postgres & Kubernetes Component #8767
Conversation
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack. |
The icon needs to be created of component, not of model Postgres and Kubernetes are models. So you will have to create an Icon for the Postgres Cluster and Kubernetes Endpoints. |
Thanks @ritiksaxena124, does I have to create something like: |
@ptdatta could you please tell me which tool are using to create icons? Acceptable tool icons? I also want to contribute. |
Let's discuss this on the Meshery dev call tomorrow, |
Signed-off-by: Parthib <parthibdutta02@gmail.com>
Signed-off-by: Parthib <parthibdutta02@gmail.com>
Signed-off-by: Parthib <parthibdutta02@gmail.com>
@ritiksaxena124 Is it now correct? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, @ptdatta. 👍
project.inlang.json
Outdated
@@ -0,0 +1,17 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ptdatta are you going to finish this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it's already completed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ptdatta you thing that you have removed this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please deliver colored and white versions of just the icons and not the shapes.
Note, that we already have the Postgres elephant, so, you'll need to bring something else.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Notes for Reviewers
This PR fixes
#8758
#8757
round-heptagon
shape.vee
or reverseround-triangle
shape.Signed commits