Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] Update validation modal tabbed menu styling #8815

Closed
wants to merge 1 commit into from
Closed

[UI] Update validation modal tabbed menu styling #8815

wants to merge 1 commit into from

Conversation

mikenrowland
Copy link

@mikenrowland mikenrowland commented Sep 18, 2023 •
edited

Notes for Reviewers

This PR fixes #8760

Video link: Tabbed menu styling

Signed commits

  • Yes, I signed my commits.

@github-actions github-actions bot added the component/ui User Interface label Sep 18, 2023
@mikenrowland mikenrowland changed the title [UI]: Update validation modal tabbed menu styling [UI] Update validation modal tabbed menu styling Sep 18, 2023
@leecalcote
Copy link
Member

Thanks, @mikenrowland 👏

@saurabh100ni
Copy link
Contributor

hey @mikenrowland
Let's discuss this in today's Meshery Development call
Please add this to the Meeting Doc if it isn't already there: https://docs.google.com/document/d/1Dg4Uz9rGTuGHmYZwIt47z1j5x3LmnpxD1M1SgypAkQ0/edit

@mikenrowland
Copy link
Author

mikenrowland commented Sep 20, 2023 •
edited

hey @mikenrowland Let's discuss this in today's Meshery Development call Please add this to the Meeting Doc if it isn't already there: https://docs.google.com/document/d/1Dg4Uz9rGTuGHmYZwIt47z1j5x3LmnpxD1M1SgypAkQ0/edit

Sure @saurabh100ni, the PR has been added to the docs.
I have a calendar meeting clash for 3pm though, so I will be joining the meeting a little bit later, at about 3:10pm. Thanks

@mikenrowland mikenrowland force-pushed the feature/mikenrowland/validation-modal-tab-menu-styling branch from 318e048 to 4b98684 Compare September 20, 2023 16:02
leecalcote
leecalcote requested changes Sep 23, 2023
View reviewed changes
ui/components/ConfirmationModal.js Outdated Show resolved Hide resolved
@mikenrowland mikenrowland force-pushed the feature/mikenrowland/validation-modal-tab-menu-styling branch from 4b98684 to 96d98fe Compare September 23, 2023 13:28
hamza-mohd
hamza-mohd approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@hamza-mohd hamza-mohd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked for me.

@sudhanshutech
Copy link
Member

@mikenrowland merge conflicts

sudhanshutech
sudhanshutech requested changes Sep 27, 2023
View reviewed changes
ui/components/ConfirmationModal.js Outdated Show resolved Hide resolved
ui/components/ConfirmationModal.js Outdated Show resolved Hide resolved
ui/components/ConfirmationModal.js Outdated Show resolved Hide resolved
@saurabh100ni
Copy link
Contributor

hey @mikenrowland
If you have any updates, Let's discuss them in today's Meshery Development call
Please add this to the Meeting Doc if you would :)
https://docs.google.com/document/d/1Dg4Uz9rGTuGHmYZwIt47z1j5x3LmnpxD1M1SgypAkQ0/edit

@mikenrowland
Update validation modal tabbed menu styling
cb0acb2 
Signed-off-by: Michael Ngwube <michaelrowland.ng@gmail.com>
@mikenrowland mikenrowland force-pushed the feature/mikenrowland/validation-modal-tab-menu-styling branch from 96d98fe to cb0acb2 Compare September 27, 2023 16:52
@sudhanshutech
Copy link
Member

Looks good, but is it was necessary to add new theme references. I guess those colors were already there in the same file. Will you take a look again and show updated screenshot or recording

@mikenrowland
Copy link
Author

Looks good, but is it was necessary to add new theme references. I guess those colors were already there in the same file. Will you take a look again and show updated screenshot or recording

I believe it was necessary for proper naming of the references with regards to this use case.

@mikenrowland
Copy link
Author

Screen.Recording.2023-09-28.at.13.21.34.mov

@stale Stale
Copy link

stale bot commented Nov 24, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Nov 24, 2023
@stale Stale
Copy link

stale bot commented Dec 5, 2023

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leecalcote leecalcote leecalcote requested changes

@sudhanshutech sudhanshutech sudhanshutech requested changes

@hamza-mohd hamza-mohd hamza-mohd approved these changes

@ritiksaxena124 ritiksaxena124 Awaiting requested review from ritiksaxena124

Assignees
No one assigned
Labels
component/ui User Interface issue/stale Issue has not had any activity for an extended period of time
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UI] Update styling of tabbed menu in validation modal
5 participants
@mikenrowland @leecalcote @saurabh100ni @sudhanshutech @hamza-mohd