[UI] feat: Setup prettier and moved lint-staged to its own file #8827
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,17 @@ | ||
| { | ||
| "presets": [ | ||
| "next/babel" | ||
| ], | ||
| "plugins": [ | ||
| "relay", | ||
| [ | ||
| "istanbul", | ||
| { | ||
| "exclude": [ | ||
| "**/*.spec.js", | ||
| "pages/_document.js" | ||
| ] | ||
| } | ||
| ] | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,4 +7,4 @@ package-lock.json | |
| nodemon.json | ||
| lib/ | ||
| cypress/ | ||
| **/__generated__/** | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,99 +1,60 @@ | ||
| module.exports = { | ||
| env: { | ||
| browser: true, | ||
| es6: true, | ||
| node: true, // tells the parser that we are using nodejs | ||
| }, | ||
|
|
||
| settings: { | ||
| react: { | ||
| version: require('./package.json').dependencies.react, | ||
| }, | ||
| }, | ||
| extends: [ | ||
| 'eslint:recommended', | ||
| 'plugin:react/recommended', | ||
| 'plugin:cypress/recommended', | ||
| 'next', | ||
| 'plugin:prettier/recommended', | ||
| ], | ||
| globals: { | ||
| Atomics: 'readonly', | ||
| SharedArrayBuffer: 'readonly', | ||
| globalThis: 'readonly', | ||
| }, | ||
| parser: '@babel/eslint-parser', | ||
| parserOptions: { | ||
| ecmaFeatures: { | ||
| jsx: true, | ||
| }, | ||
| ecmaVersion: 2018, | ||
| sourceType: 'module', | ||
| }, | ||
| plugins: ['react', 'cypress', 'prettier'], | ||
| rules: { | ||
| '@next/next/no-img-element': 'off', | ||
| 'react-hooks/rules-of-hooks': 'warn', | ||
| 'react-hooks/exhaustive-deps': 'off', | ||
| 'jsx-a11y/alt-text': 'off', | ||
| 'valid-typeof': 'warn', | ||
| 'no-trailing-spaces': 'error', | ||
| 'block-spacing': 'error', | ||
| 'brace-style': ['error', '1tbs'], | ||
| 'react/react-in-jsx-scope': 'off', | ||
| 'no-undef': 'error', | ||
| 'react/jsx-uses-vars': [2], | ||
| 'react/jsx-no-undef': 'error', | ||
| 'no-console': 0, | ||
| 'no-unused-vars': 'error', | ||
| 'react/jsx-key': 'warn', | ||
| 'no-dupe-keys': 'error', | ||
| 'react/jsx-filename-extension': [ | ||
| 1, | ||
| { | ||
| extensions: ['.js', '.jsx'], | ||
| }, | ||
| ], | ||
| 'react/prop-types': 'off', | ||
| 'prettier/prettier': 'warn', | ||
| }, | ||
| }; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| module.exports = { | ||
| // Lint & Prettify TS and JS files | ||
| '**/*.(ts|tsx|js|jsx)': (filenames) => [`npm run lint`, `npm run format`], | ||
|
|
||
| // Prettify only Markdown and JSON files | ||
| '**/*.(md|json)': (filenames) => `npx prettier --write ${filenames.join(' ')}`, | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| *.svg | ||
| *.ico | ||
| *.css | ||
|
|
||
| */.DS_Store | ||
| assets/** | ||
| .next | ||
| package-lock.json | ||
| public | ||
| node_modules | ||
| next-env.d.ts | ||
| next.config.js | ||
| .eslintrc.js | ||
| **/__generated__/** |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| arrowParens: always | ||
| bracketSameLine: false | ||
| bracketSpacing: true | ||
| jsxSingleQuote: false | ||
| proseWrap: preserve | ||
| quoteProps: as-needed | ||
| semi: true | ||
| singleQuote: true | ||
| tabWidth: 2 | ||
| trailingComma: all | ||
| printWidth: 100 | ||
| useTabs: false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| import { promisifiedDataFetch } from '../lib/data-fetch'; | ||
|
|
||
| export const getConnectionStatusSummary = async () => { | ||
| return await promisifiedDataFetch('/api/integrations/connections/status'); | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,15 @@ | ||
| import axios from 'axios'; | ||
|
|
||
| const instance = axios.create({ | ||
| withCredentials: true, // for pushing client-cookies in all requests to server | ||
| }); | ||
|
|
||
| instance.interceptors.response.use((response) => { | ||
| if (response.request.responseURL.includes('/auth/login')) { | ||
| window.location = '/auth/login'; | ||
| window.onbeforeunload = null; | ||
| } | ||
| return response; | ||
| }); | ||
|
|
||
| export default instance; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nebula-aac All looks good though I have a question should be doing same for meshery cloud as we are not using next Image there too, and getting bunch of lint error on that or we should not silence it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yashsharma1911 I have it turned off now because in using Image from Next, it requires the width and height to be used, and some of the images we have, we're doing without. It would be a good idea to turn it off in Meshery Cloud too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yashsharma1911 can you approve again? I updated the lint staged to fix the linting at commits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure