Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kubernetes components styles #9066

Merged
merged 3 commits into from Oct 15, 2023

Conversation

aabidsofi19
Copy link
Contributor

@aabidsofi19 aabidsofi19 commented Oct 10, 2023

Notes for Reviewers

This PR fixes #

  • Adds completeSvg for the cylinder shapes
  • remove backgroundOpacity for completeSvg's
  • keep the border .

Signed commits

  • Yes, I signed my commits.

Signed-off-by: aabidsofi19 <mailtoaabid01@gmail.com>
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aabidsofi19 is there a specific extension release that needs to marry with this update? Here's what I get when using the CSI Node in this branch:
Screenshot 2023-10-14 at 6 24 39 PM

@aabidsofi19 aabidsofi19 merged commit 56798bc into meshery:master Oct 15, 2023
6 checks passed
@aabidsofi19
Copy link
Contributor Author

yup this is dependent on the style map pr , which is merged now .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants