Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated aks.md and added helm.md #9141

Merged

Conversation

aboobakersiddiqr63
Copy link
Contributor

Notes for Reviewers

  • Updated aks.md & added helm.md

This PR fixes #9055

Signed commits

  • [ ✓] Yes, I signed my commits.

Signed-off-by: Aboobaker Siddiq R <aboobakersiddiq63@gmail.com>
@github-actions github-actions bot added the area/docs Documentation update needed label Oct 18, 2023
@l5io
Copy link
Collaborator

l5io commented Oct 18, 2023

@saurabh100ni
Copy link
Contributor

Thanks for raising the PR, let's Discuss this in the Meshery Development Call today,
Please add this as an agenda in the Doc : Doc


1. Verfiy you connection to an Azure Kubernetes Services Cluster using Azure CLI.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aboobakersiddiqr63 typo *Verify

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhijeetgauravm Thanks for pointing out fixed the issue in the latest commit

Signed-off-by: Aboobaker Siddiq R <aboobakersiddiq63@gmail.com>
@l5io
Copy link
Collaborator

l5io commented Oct 18, 2023

</ol>
</div>

## Install Meshery on Your Kubernetes Cluster Using Helm V3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Install Meshery on Your Kubernetes Cluster Using Helm V3
## Install Meshery on Your Kubernetes Cluster Using Helm


{% capture code_content %}export POD_NAME=$(kubectl get pods --namespace meshery -l "app.kubernetes.io/name=meshery,app.kubernetes.io/instance=meshery" -o jsonpath="{.items[0].metadata.name}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where else is this information being captured?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm copying and capturing in the central Kubernetes install page.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to delete, though, once the dust has settled.

Signed-off-by: Aboobaker Siddiq R <aboobakersiddiq63@gmail.com>
@l5io
Copy link
Collaborator

l5io commented Oct 19, 2023

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work getting a page going specifically for Helm. 👍

@leecalcote leecalcote merged commit 6e62f69 into meshery:master Oct 24, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation update needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Update AKS Documentation for Service-level Port Forwarding
5 participants