Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MeshSync] Expose MeshSync Discovered Resources #9143

Merged
merged 10 commits into from Oct 19, 2023

Conversation

theBeginner86
Copy link
Member

@theBeginner86 theBeginner86 commented Oct 18, 2023

Notes for Reviewers

This PR adds API (/system/meshsync/resources) to fetch MeshSync Discovered Resources.

Screenshot 2023-10-18 at 6 52 25 PM

This PR fixes #

Earlier, it was part of this PR but then I moved it out considering the urgency of GO pkg update.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@github-actions github-actions bot added the area/docs Documentation update needed label Oct 18, 2023
…re/43

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@l5io
Copy link
Collaborator

l5io commented Oct 18, 2023

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@theBeginner86
Copy link
Member Author

According to our discussion on today's Meshery Dev call:
I've made the support for spec/status as optional. Also, added support to filter based on clsuterId

@theBeginner86
Copy link
Member Author

Updated Meshery API Spreadsheet

@l5io
Copy link
Collaborator

l5io commented Oct 18, 2023

@theBeginner86
Copy link
Member Author

@Yashsharma1911 @senali-d looks good?

@leecalcote leecalcote merged commit 7c93ff8 into meshery:master Oct 19, 2023
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation update needed component/server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants