Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added description of Docs capability for "alerts" #9179

Closed
wants to merge 5 commits into from

Conversation

Debaditya-Som
Copy link
Contributor

Notes for Reviewers

Changes Made:

This PR fixes #9094

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Debaditya Som <121785700+Debaditya-Som@users.noreply.github.com>
@welcome
Copy link

welcome bot commented Oct 24, 2023

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while performing a commit.

@github-actions github-actions bot added the area/docs Documentation update needed label Oct 24, 2023
@Debaditya-Som Debaditya-Som changed the title Enhanced contributing-docs.html Added description of Docs capability for "alerts" Oct 24, 2023
@l5io
Copy link
Collaborator

l5io commented Oct 24, 2023

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting forth effort here, @Debaditya-Som 👍

@saurabh100ni
Copy link
Contributor

Let's discuss this on the Meshery dev call tomorrow at 7:30 pm IST / 9:00 am CT,
Please add this as your agenda item in Docs: https://docs.google.com/document/d/1Dg4Uz9rGTuGHmYZwIt47z1j5x3LmnpxD1M1SgypAkQ0/edit

@Debaditya-Som
Copy link
Contributor Author

Let's discuss this on the Meshery dev call tomorrow at 7:30 pm IST / 9:00 am CT, Please add this as your agenda item in Docs: https://docs.google.com/document/d/1Dg4Uz9rGTuGHmYZwIt47z1j5x3LmnpxD1M1SgypAkQ0/edit

Yes surely

@Debaditya-Som
Copy link
Contributor Author

Thanks for putting forth effort here, @Debaditya-Som 👍

You're welcome :)

@coder12git
Copy link
Contributor

@Debaditya-Som Let me know, what help you need :)

@coder12git
Copy link
Contributor

coder12git commented Oct 25, 2023

@Debaditya-Som actually you need to add a new section describing "alerts.html" in this file -docs/pages/project/contributing/contributing-docs.md, not the one you did , that version of the docs is archived now .

@Debaditya-Som
Copy link
Contributor Author

@Debaditya-Som actually you need to add a new section describing "alerts.html" in this file -docs/pages/project/contributing/contributing-docs.md, not the one you did , that version of the docs is archived now .

Okay got it, so I need to create a section in the mentioned file. Could you tell me whether the documentation that I have done in the archived version is accurate or not?

@leecalcote
Copy link
Member

@coder12git ?

@coder12git
Copy link
Contributor

coder12git commented Oct 27, 2023

@Debaditya-Som actually you need to add a new section describing "alerts.html" in this file -docs/pages/project/contributing/contributing-docs.md, not the one you did , that version of the docs is archived now .

Okay got it, so I need to create a section in the mentioned file. Could you tell me whether the documentation that I have done in the archived version is accurate or not?

@Debaditya-Som looks good to me, just move the given content to the specified file!

Signed-off-by: Debaditya Som <121785700+Debaditya-Som@users.noreply.github.com>
Signed-off-by: Debaditya Som <121785700+Debaditya-Som@users.noreply.github.com>
@Debaditya-Som
Copy link
Contributor Author

Debaditya-Som commented Oct 27, 2023

@Debaditya-Som looks good to me, just move the given content to the specified file!

@leecalcote ,@coder12git
I have made the necessary changes, kindly review it.

@coder12git
Copy link
Contributor

@Debaditya-Som looks good to me, just move the given content to the specified file!

@leecalcote ,@coder12git I have made the necessary changes, kindly review it.

@Debaditya-Som looks good to me, just move the given content to the specified file!

@leecalcote ,@coder12git I have made the necessary changes, kindly review it.

Also, do the changes suggested by me in the content and you need to revert your commits too so that only those changes will be shown in which you have done changes, in your case just this file docs/pages/project/contributing/contributing-docs.md.

@Debaditya-Som
Copy link
Contributor Author

Also, do the changes suggested by me in the content and you need to revert your commits too so that only those changes will be shown in which you have done changes, in your case just this file docs/pages/project/contributing/contributing-docs.md.

Yes, I have also made the changes that was suggested by you, only the updated commit, that is the one made in the specified file is made and the previous changes were reverted.

@@ -954,434 +954,47 @@ <h3 id="assign">Assign</h3>
<div class="language-plaintext highlighter-rouge"><div class="highlight"><pre class="highlight"><code> {% assign variable1 = true %}
</code></pre></div></div>

<h3 id="Alerts">Alerts</h3>
The <code>alerts.html</code> file is used to format and display notes, warnings, and other informational callouts in Meshery.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meshery Docs has a common include file alert.html , to provide consistent formatting for notes, warnings, and various informative callouts intended for the readers.

The <code>alerts.html</code> file is used to format and display notes, warnings, and other informational callouts in Meshery.
It provides a consistent and visually appealing way to draw the user's attention to important information.
<p>
To use the <code>alerts.html</code> feature, include the following code snippet in your documentation:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File is alert.html not alerts.html

@@ -356,4 +356,36 @@ The assign tag is used to create a new variable. It is written in the following
{% include code.html code=code_content %}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@Debaditya-Som Add the alert section just after this line.

@coder12git
Copy link
Contributor

Also, do the changes suggested by me in the content and you need to revert your commits too so that only those changes will be shown in which you have done changes, in your case just this file docs/pages/project/contributing/contributing-docs.md.

Yes, I have also made the changes that was suggested by you, only the updated commit, that is the one made in the specified file is made and the previous changes were reverted.

By revert, i mean revert your PR to only those commits which shows changes in the suggested file.

Signed-off-by: Debaditya Som <121785700+Debaditya-Som@users.noreply.github.com>
Signed-off-by: Debaditya Som <121785700+Debaditya-Som@users.noreply.github.com>
@Debaditya-Som
Copy link
Contributor Author

By revert, i mean revert your PR to only those commits which shows changes in the suggested file.

image

I'm facing this error while reverting the initial commit

@Debaditya-Som
Copy link
Contributor Author

I am facing merge conflict while working on this branch, I have created a new branch and submitted a new PR : #9226 , kindly review that PR and ignore this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation update needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Add description of Docs capability for "alerts"
5 participants