Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes in Connections/MeshSync tables #9265

Merged
merged 1 commit into from Nov 2, 2023

Conversation

sudhanshutech
Copy link
Member

@sudhanshutech sudhanshutech commented Nov 1, 2023

Notes for Reviewers

This PR fixes #

  1. Search bug in meshsync
  2. add column functionality
  3. fix pagination
  4. remove sort for metadata for sorting because that is not a column(bug)
  5. some ui enhancements

image

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Sudhanshu Dasgupta <dasguptashivam23@gmail.com>
@github-actions github-actions bot added the component/ui User Interface label Nov 1, 2023
}}
>
<SearchBar
onSearch={(value) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why need an extra function?

ui/components/connections/MeshsyncTable.js Show resolved Hide resolved
ui/components/connections/MeshsyncTable.js Show resolved Hide resolved
@sudhanshutech sudhanshutech merged commit 41acd80 into meshery:master Nov 2, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants