Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[policy] Add Sibling Policy #9410

Merged
merged 13 commits into from Nov 23, 2023

Conversation

theBeginner86
Copy link
Member

Notes for Reviewers

This PR fixes #

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
leecalcote
leecalcote previously approved these changes Nov 21, 2023
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (so far)

…re/63

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
theBeginner86 and others added 3 commits November 22, 2023 20:22
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@aabidsofi19
Copy link
Contributor

aabidsofi19 commented Nov 23, 2023

@theBeginner86 does it make ense to transform the response to :

group_objects_with_matching_fields : {
    label : { 
        <label-key> : [ { id : <component-id> , name : <component-name> } ... ] 
    } , 
   annotation : {} ,
   some-other-field : ....  // 
   }
}

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
…er86/meshery into theBeginner86/chore/63

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@theBeginner86
Copy link
Member Author

theBeginner86 commented Nov 23, 2023

@theBeginner86 does it make ense to transform the response to :

group_objects_with_matching_fields : {
    label : { 
        <label-key> : [ { id : <component-id> , name : <component-name> } ... ] 
    } , 
   annotation : {} ,
   some-other-field : ....  // 
   }
}

done!

Following is the response:

group_objects_with_matching_fields : {
    labels : { 
        <label-key> : {
             <label-value>:  [ { id : <component-id> , name : <component-name> } ... ] }
    } , 
   annotations : {} ,
   some-other-field : ....  // 
   }
}

Here is a link to rego playground where you can test quickly https://play.openpolicyagent.org/p/YcqqNCLuJx 😄

@aabidsofi19
Copy link
Contributor

@theBeginner86 Thank you 🚀

@aabidsofi19 aabidsofi19 merged commit 1a0d459 into meshery:master Nov 23, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants