Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] fix build UI workflow #9578

Closed
wants to merge 4 commits into from

Conversation

Shiva953
Copy link
Contributor

@Shiva953 Shiva953 commented Dec 5, 2023

Notes for Reviewers

This PR addresses #9566

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Shiva953 <b22070@students.iitmandi.ac.in>
Signed-off-by: Shiva953 <b22070@students.iitmandi.ac.in>
Signed-off-by: Shiva953 <b22070@students.iitmandi.ac.in>
@github-actions github-actions bot added the area/ci Continuous Integration label Dec 5, 2023
@abhijeetgauravm
Copy link
Contributor

Hey @Shiva953 Let's discuss this on Meshery Development Meeting today at 8:30 PM IST / 9 AM Central time. Please add this as an agenda item in the meeting minutes.

@leecalcote
Copy link
Member

Hey @Shiva953 Let's discuss this on Meshery Development Meeting today at 8:30 PM IST / 9 AM Central time. Please add this as an agenda item in the meeting minutes.

@Shiva953 did you discuss the merits of this on last week's Meshery CI meeting?

@leecalcote
Copy link
Member

Hey @Shiva953 Let's discuss this on Meshery Development Meeting today at 8:30 PM IST / 9 AM Central time. Please add this as an agenda item in the meeting minutes.

@Shiva953 did you discuss the merits of this on last week's Meshery CI meeting?

@Shiva953 did you discuss the merits of this on last week's Meshery CI meeting?

Copy link
Contributor

@MUzairS15 MUzairS15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead you can use the expressions in GH actions for each of the steps in that job

if: {{ failure() }}
run: exit 1

Copy link

@leecalcote leecalcote added the issue/remind Issue progress check label Jan 23, 2024
@leecalcote
Copy link
Member

@Shiva953 still with us?

Copy link

Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@leecalcote
Copy link
Member

@Shiva953 have you abandoned this effort?

Copy link

stale bot commented Apr 11, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Apr 11, 2024
Copy link

stale bot commented Apr 22, 2024

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Continuous Integration issue/remind Issue progress check issue/stale Issue has not had any activity for an extended period of time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants