Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spaces] Finalize support for Environments #9618

Merged
merged 18 commits into from Dec 13, 2023

Conversation

theBeginner86
Copy link
Member

@theBeginner86 theBeginner86 commented Dec 11, 2023

Notes for Reviewers

  1. Adds support for orgs
  2. Updates APIs docs
  3. Adds new redux store for selected org
  4. Use capability for env
  5. Cleanup env APIs

This PR fixes #

Meshery Provider:
Screenshot 2023-12-13 at 11 00 06 PM

None Provider:

Screenshot 2023-12-13 at 11 00 17 PM

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@theBeginner86 theBeginner86 changed the title [extension] Add support for Environments [Spaces] Add support for Environments Dec 11, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (39a99c4) 10.26% compared to head (817188c) 10.25%.
Report is 40 commits behind head on master.

Files Patch % Lines
server/handlers/organization_handler.go 0.00% 15 Missing ⚠️
server/cmd/main.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9618      +/-   ##
==========================================
- Coverage   10.26%   10.25%   -0.01%     
==========================================
  Files         137      138       +1     
  Lines       21886    21906      +20     
==========================================
  Hits         2246     2246              
- Misses      19285    19305      +20     
  Partials      355      355              
Flag Coverage Δ
unittests 10.25% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@theBeginner86 theBeginner86 changed the title [Spaces] Add support for Environments [Spaces] Finalize support for Environments Dec 11, 2023
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@github-actions github-actions bot added the component/ui User Interface label Dec 12, 2023
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@github-actions github-actions bot added the area/docs Documentation update needed label Dec 13, 2023
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@l5io
Copy link
Collaborator

l5io commented Dec 13, 2023

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@l5io
Copy link
Collaborator

l5io commented Dec 13, 2023

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@l5io
Copy link
Collaborator

l5io commented Dec 13, 2023

@theBeginner86
Copy link
Member Author

theBeginner86 commented Dec 13, 2023

Merging this now...
Will be creating a subsequent PR for docs update about the inclusion of Orgs and what it means for Remote Providers. And separately a PR for workspaces.

// @leecalcote

@theBeginner86 theBeginner86 merged commit 72b77c9 into meshery:master Dec 13, 2023
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation update needed component/server component/ui User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants