Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nil pointer errors and updated the keys new URL path #9731

Merged
merged 2 commits into from Dec 27, 2023

Conversation

Yashsharma1911
Copy link
Contributor

Notes for Reviewers

This PR fixes #9721

We already exposed keys in Meshery, however since there are new updates in URL I updated the path in this PR, also there were a couple of nil pointer errors coming which this PR also fixes.

I created a new handler specific for keys to not increase extra LOC in only users handlers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: yash sharma <yashsharma2572@gmail.com>
Copy link

github-actions bot commented Dec 27, 2023

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (71c6b21) 10.15% compared to head (9a8b520) 10.12%.
Report is 33 commits behind head on master.

Files Patch % Lines
server/handlers/keys_handler.go 0.00% 16 Missing ⚠️
server/router/server.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9731      +/-   ##
==========================================
- Coverage   10.15%   10.12%   -0.04%     
==========================================
  Files         139      140       +1     
  Lines       22115    22187      +72     
==========================================
  Hits         2246     2246              
- Misses      19514    19586      +72     
  Partials      355      355              
Flag Coverage Δ
unittests 10.12% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: yash sharma <yashsharma2572@gmail.com>
@Yashsharma1911
Copy link
Contributor Author

// @theBeginner86

@Yashsharma1911 Yashsharma1911 merged commit 7b85541 into meshery:master Dec 27, 2023
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementation of permission framework in Meshery UI
1 participant