Registry log

[Jougan-0]

Notes for Reviewers

This PR fixes #9555

Signed commits

• Yes, I signed my commits.

[github-actions]

[Jougan-0]

meshery/meshkit#427

[Jougan-0]

Here's the video clip of the new features I went the thought that people would register some model and if they wanna see the logs of the new model they could refresh the webpage itself rather than restarting the server and will get the quantity of the entities that are registered successfully or not .
Screencast from 2024-01-03 21-44-21.webm

[Jougan-0]

It's send the event to the ui on the first load of the page as well as when the page is refreshed

[Jougan-0]

@MUzairS15 should i use this to sync the registering and fetching of the data i Don't think it is necessary just a fail safe if someone opens the server if the entites are still being registered can you confirm this

meshery/server/meshmodel/helper.go

Line 167 in dd67ed6

meshmodel.Mutex.Lock()

[MUzairS15]

No not required

[leecalcote]

@MUzairS15 is there some existing mechanism that we should be using or do we need this new paradigm of storing and displaying log files?

[leecalcote]

Good of you to stick with today's extra meeting, @Jougan-0 👍

[Jougan-0]

Good of you to stick with today's extra meeting, @Jougan-0 👍

It was fascinating to realize that I haven't yet scratched the surface of the project and still have a lot to learn, for me to be more comfortable and useful in future discussions.

[MUzairS15]

These mutex is for shared variables right used in registryLog function?
If so move this lock smd unlock within that function call.

[Jougan-0]

@MUzairS15
but we are locking as the registering is started when it enters the watchComponent for the first time
the main aim of this mutex is that the function GetmeshmodelRegistrant shouldn't be displaying the value if the registration is not complete and unlock it when the registration is complete . That is why we are locking it at the start and then unlocking it when the registration is complete .
https://github.com/meshery/meshery/blob/e2bbe45b50d5acdb9493bab4fbf90b0998b4db36/server/handlers/component_handler.go#L1378

[MUzairS15]

Still not according to API design.
@Jougan-0 The functionality that you are defining in the PR is crucial, while the output that we get from the current implementation is nice, the approach is not ideal.

How do you ensure that the registration might have been completed by the time UI makes a request to this endpoint?

My question still stands, if the server is doing the registration why you cannot consolidate all errors and send it all at once?
See the errorChan channel it listens to all the errors encountered, can't you send in more details on this channel model, component and error or the event object itself, store it in an array, and call the cancel function of the passed in context (when registration completes), when you will call the cancel func the ctx.Done case will be called, there you can iterate over that array and add in more details (i.e. summary, x model, y comps failed to register..... )

[Jougan-0]

Screencast from 2024-01-09 06-22-53.webm
@MUzairS15 the reason for not using the errorChan is the same I am displaying in the video when the return type of schema error in meshkit is nil the code works fine and these components are not registered but if we return an error such as schema empty the registration breaks I don't know the reason for it but this doesn't make sense i searched but i don't know why we exit quietly when the schema is empty and if we return an error the code breaks so i opt for using the meshkit to store the error and store their in meshkit itself when the entites try to register .

[MUzairS15]

API design is still not accurate, invoking the event from UI is also inaccurate, find a way to send events from the server.

[leecalcote]

@MUzairS15, fyi, @Jougan-0 made a hard commitment to complete this effort by Friday, Jan 19th. If not completed by then, we'll need to toss in the towel here and carry forward these concerns separately under this issue: #9943

[Jougan-0]

• Tasks done:

• 1. Stored the file at .meshery/content folder

• 2. New viper variable for "SERVER_CONTENT_FOLDER"

• 3. The metadata has a download link and view link

• 4. New function to create a download and view link just by passing a file path

• 5. Change the success type to informational event

• Tasks Left:

• 1. Proper api call

• 2. Send event directly from the server currently event is invoked from ui

The tasks are left because i can't figure out how can i send the event directly from the function that has logs the values to the terminal because the user.ID is not present when the make server command is ran.

[leecalcote]

@Jougan-0 use all zeros for the user ID.

[Jougan-0]

@Jougan-0 use all zeros for the user ID.

@leecalcote please correct me if I am wrong here but first the event is created with new event and then we do persistEvent and then we send the using the
erh.handlerConfig.EventBroadcaster.Publish(userID, successEvent)

while setting the id to all 0s nothing is shown in the notification center

ID := "00000000-0000-0000-0000-000000000000"
	userID := uuid.FromStringOrNil(ID)

I am using this id

[MUzairS15]

Thanks @Jougan-0 for your effort, but we will not be proceeding with the approach proposed.
I hope you find some other issue to work upon, as for beginners this issue isn't easy to tackle.