New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capitalize button text in Meshery UI modals #9895
Conversation
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack. |
Signed-off-by: aayush <kingaayusharora@gmail.com>
Signed-off-by: aayush <kingaayusharora@gmail.com>
efbeb99
to
aed33b8
Compare
Signed-off-by: aayush <kingaayusharora@gmail.com>
Hi @Aayush2111 , You're welcome at the meeting Check to community calendar for more details of meetings at Layers. |
@Aayush2111 merge conflicts... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix merge conflicts, please.
Signed-off-by: kingA <kingaayusharora@gmail.com>
@ritiksaxena124 look good? |
Looks good to me 👍. I wonder if instead of hardcoding the button text we can just add the CSS property to the button component so that it automatically converts the text to uppercase @Aayush2111. |
beb960e
to
928d64d
Compare
Make sense. @Aayush2111 any progress? This modals uses genric modal, you need to add style to that modal, a one line change. |
Sure, actually, the other buttons were also hardcoded, so I followed the same structure. Do you want me to remove the hardcoding and add CSS properties to them as well? |
Signed-off-by: aayush <kingaayusharora@gmail.com>
Signed-off-by: aayush <kingaayusharora@gmail.com>
Signed-off-by: aayush <kingaayusharora@gmail.com>
@sudhanshutech @ritiksaxena124 |
Calling on @sudhanshutech and @senali-d for their 👀 on. |
Thanks @Aayush2111 for you to covering this, this issue is fixed now . Lets have you assigned some other issue. |
Notes for Reviewers
This PR fixes #9846
Signed commits