Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalize button text in Meshery UI modals #9895

Closed
wants to merge 14 commits into from

Conversation

Aayush2111
Copy link

@Aayush2111 Aayush2111 commented Jan 9, 2024

Notes for Reviewers

This PR fixes #9846

Signed commits

  • Yes, I signed my commits.

Copy link

welcome bot commented Jan 9, 2024

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while performing a commit.

@github-actions github-actions bot added the component/ui User Interface label Jan 9, 2024
Copy link

github-actions bot commented Jan 9, 2024

Signed-off-by: aayush <kingaayusharora@gmail.com>
Signed-off-by: aayush <kingaayusharora@gmail.com>
Signed-off-by: aayush <kingaayusharora@gmail.com>
@saurabh100ni
Copy link
Contributor

Hi @Aayush2111 ,
Thanks for your PR! I encourage you to share this in the Meshery Development Meeting tomorrow at 8:30 PM IST. Share your screen, and walk us through it. It's cool to take and share feedback. Check the Doc here to include this PR.

You're welcome at the meeting

Check to community calendar for more details of meetings at Layers.

@sudhanshutech
Copy link
Member

@Aayush2111 merge conflicts...

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix merge conflicts, please.

Signed-off-by: kingA <kingaayusharora@gmail.com>
@leecalcote leecalcote removed their request for review January 12, 2024 17:28
@leecalcote
Copy link
Member

@ritiksaxena124 look good?

@ritiksaxena124
Copy link
Contributor

Looks good to me 👍. I wonder if instead of hardcoding the button text we can just add the CSS property to the button component so that it automatically converts the text to uppercase @Aayush2111.

Signed-off-by: aayush <kingaayusharora@gmail.com>
@Aayush2111 Aayush2111 reopened this Jan 16, 2024
@sudhanshutech
Copy link
Member

Looks good to me 👍. I wonder if instead of hardcoding the button text we can just add the CSS property to the button component so that it automatically converts the text to uppercase @Aayush2111.

Make sense. @Aayush2111 any progress? This modals uses genric modal, you need to add style to that modal, a one line change.

@Aayush2111
Copy link
Author

Looks good to me 👍. I wonder if instead of hardcoding the button text we can just add the CSS property to the button component so that it automatically converts the text to uppercase @Aayush2111.

Make sense. @Aayush2111 any progress? This modals uses genric modal, you need to add style to that modal, a one line change.

Sure, actually, the other buttons were also hardcoded, so I followed the same structure. Do you want me to remove the hardcoding and add CSS properties to them as well?
Screenshot (12)
Screenshot (13)

@Aayush2111
Copy link
Author

@sudhanshutech @ritiksaxena124
Suggesting something like this?

@leecalcote
Copy link
Member

Calling on @sudhanshutech and @senali-d for their 👀 on.

@sudhanshutech
Copy link
Member

Thanks @Aayush2111 for you to covering this, this issue is fixed now . Lets have you assigned some other issue.
For context you need to add style to the Modal.js file which is the root file to serve this modals. This change will affect only here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Capitalize button text in Meshery UI modals
5 participants