fix(ci/lint): fix failing lint checks #212
Conversation
Signed-off-by: pk-218 <53428217+pk-218@users.noreply.github.com>
|
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. |
theBeginner86
added
area/ci
|
That's strange. When I used act to run the CI locally, I found no issues. |
|
Maybe it has improved. I never really had any luck with act. |
|
If not |
Signed-off-by: pk-218 <53428217+pk-218@users.noreply.github.com>
I personally use |
| files := make([]fs.FileInfo, 0, len(entries)) | ||
| for _, entry := range entries { | ||
| file, err := entry.Info() | ||
| if err != nil { | ||
| return err | ||
| } | ||
| files = append(files, file) | ||
| } | ||
|
|
There was a problem hiding this comment.
@pk-218 what's the need for this? Is this part of lint failures? 🤔
There was a problem hiding this comment.
The lint checks were failing here since ioutil.ReadDir is deprecated
As per the documentation, the replacement is os.ReadDir but there is a change in the method return value. Hence, to accommodate the changes, I had to add this code.
|
Same, that's how I can catch and fix these failing lint checks xD |
|
Thanks for your contribution to the Layer5 community! 🎉
|
Signed-off-by: pk-218 53428217+pk-218@users.noreply.github.com
Description
This PR fixes #203
Notes for Reviewers
Signed commits