Fix import modal errors coming because of multiple wild card #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yash sharma <yashsharma2572@gmail.com>
Yashsharma1911
commented
Sep 5, 2023
Comment on lines
-37
to
+46
| "deployment", | ||
| "observability", | ||
| "resiliency", | ||
| "scaling", | ||
| "security", | ||
| "traffic-management", | ||
| "troubleshooting", | ||
| "workloads" | ||
| "Deployment", | ||
| "Observability", | ||
| "Resiliency", | ||
| "Scaling", | ||
| "Security", | ||
| "Traffic-management", | ||
| "Troubleshooting", | ||
| "Workloads" | ||
| ], | ||
| "default": "deployment", | ||
| "default": "Deployment", |
There was a problem hiding this comment.
This is not related to issue but there is an issue coming when we publish catalog we send type as deployment( for example) but when we fetch we get Deployment with D as uppercase and which causes issues of value is not showing in type field in info modal because Deplyoment does not match with any options
|
These changes fix the issue
Fixed
|
|
Merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #
Issue
Import modal is crashing with error
Notes for Reviewers
"*" is what we call it wild card, as per documentation this is right approach to use, so for now I'm fixing it with removing wild card and will investigate if that issue still comes in after updating RJSF
Signed commits