Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New return types to RegisterEnity and New errror codes #485

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Jougan-0
Copy link
Contributor

@Jougan-0 Jougan-0 commented Mar 26, 2024

Description

This PR fixes #

Notes for Reviewers
New return types added so that can verify if the Registry error was because of model or registrant for the particular entity
Few new error codes too.

Signed commits

  • Yes, I signed my commits.

Jougan-0 and others added 4 commits March 15, 2024 06:00
Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
@Jougan-0 Jougan-0 mentioned this pull request Mar 26, 2024
1 task
@Jougan-0
Copy link
Contributor Author

@Yashsharma1911 @MUzairS15 please review here the old pr was causing issue with the release

@Jougan-0 Jougan-0 requested a review from MUzairS15 March 26, 2024 22:45
@leecalcote
Copy link
Member

@Jougan-0 will you address the failed lint checks?

@leecalcote
Copy link
Member

@Jougan-0 provide a more description PR title, please.

@Jougan-0 Jougan-0 changed the title Version19 New return types to RegisterEnity and New errror codes Mar 27, 2024
@Jougan-0
Copy link
Contributor Author

@Jougan-0 will you address the failed lint checks?

It's now my code error i guess becuase other pr have the linting error as well .
If you want me to look why the linting error is caused I'll am looking into it .
Currently I am studying the CKA and models so that I can create a proposal for the Gsoc issue .

@Jougan-0
Copy link
Contributor Author

meshery/meshery#10567

@vishalvivekm
Copy link
Member

@Jougan-0 Let's discuss this in Meshery dev call today. Add this as an agenda item to the meeting minutes, if you would :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants