New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generating components #97
Generating components #97
Conversation
Signed-off-by: Ashish test <ashishjaitiwari15112000@gmail.com>
Signed-off-by: Ashish test <ashishjaitiwari15112000@gmail.com>
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that we should be bundling copies of the kubeopenapi-jsonschema tool into this repo.
utils/manifests/getComponents.go
Outdated
|
||
import ( | ||
"github.com/layer5io/meshkit/utils" | ||
k8 "github.com/layer5io/meshkit/utils/kubernetes" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use "k8s"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, will do
Signed-off-by: Ashish test <ashishjaitiwari15112000@gmail.com>
Signed-off-by: Ashish test <ashishjaitiwari15112000@gmail.com>
Currently GetFromHelm is failing in some cases. That function has to be improved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some suggestions, please take a look. And please add the test cases for all the functions, thanks.
Where else do you suggest the binaries to be? |
Imported dynamically |
Signed-off-by: Ashish test <ashishjaitiwari15112000@gmail.com>
Signed-off-by: Ashish test <ashishjaitiwari15112000@gmail.com>
Signed-off-by: Ashish test <ashishjaitiwari15112000@gmail.com>
test code |
Signed-off-by: ashish <ashishjaitiwari15112000@gmail.com>
Signed-off-by: ashish <ashishjaitiwari15112000@gmail.com>
Signed-off-by: ashish <ashishjaitiwari15112000@gmail.com>
Signed-off-by: ashish <ashishjaitiwari15112000@gmail.com>
Signed-off-by: ashish <ashishjaitiwari15112000@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Signed-off-by: ashish <ashishjaitiwari15112000@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Adding component generation in meshkit.
Notes for Reviewers
Signed commits