Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App tab-bar not visible (anymore) with active keyboard #237

Closed
drewsed opened this issue Feb 7, 2021 · 7 comments · Fixed by #250
Closed

App tab-bar not visible (anymore) with active keyboard #237

drewsed opened this issue Feb 7, 2021 · 7 comments · Fixed by #250
Assignees
Labels
bug Something isn't working

Comments

@drewsed
Copy link

drewsed commented Feb 7, 2021

Recently the app tab-bar isn't visible anymore after clicking into the text edit field in the messages tab.

This behavior shows up on Google pixel 3 (android 11) and xperia xz2 compact (android 10)

Screenshot_20210207-125909

@timgunter
Copy link

I am also experiencing this on a moto g power running android 10. I would prefer if the tab-bar remained visible.

@geeksville
Copy link
Member

This issue has been mentioned on Meshtastic. There might be relevant details there:

https://meshtastic.discourse.group/t/android-app-1-1-44-now-up-for-alpha-testing/2446/8

@drewsed drewsed changed the title App tab-bar not visible with active keyboard App tab-bar not visible (anymore) with active keyboard Feb 8, 2021
@geeksville
Copy link
Member

interesting!

@geeksville geeksville self-assigned this Feb 9, 2021
@geeksville geeksville added the bug Something isn't working label Feb 9, 2021
@vfurman-gh
Copy link
Contributor

This is probably due to the change in how appearance of soft input is handled. I added adjustPan option here:
AndroidManifest.xml:
....
android:windowSoftInputMode="stateAlwaysHidden|adjustPan"
...
The adjustPan helps to bring edit boxes that would be otherwise hidden by the soft input to be visible. I would argue that loosing top bar is not that terrible for gaining visibility into the edit box you are editing....
To reproduce original problem, try editing the lowest edit box on the Settings screen.

@drewsed
Copy link
Author

drewsed commented Feb 11, 2021

Ah thanks for that answer, regarding the usability in the settings screen this is indeed a good way to go.

We can now close this issue or leave it open for future reference. Maybe we can add a scrollable panel in the settings tab, because there will be some more settings sometimes in future than inly these two text edits.

@drewsed
Copy link
Author

drewsed commented Feb 20, 2021

Ok, after moving the extra text edit boxes to the seperate "Advanced Settings" page it would be nice to revert to the previous mode with the fixed tab bar. what do you think?

I really don't like it to have to close the keyboard every time befor moving to other tabs. So much finger gymnastics, haha

@vfurman-gh
Copy link
Contributor

vfurman-gh commented Feb 22, 2021

Thanks for reminding, here is a PR #250. On my device, this fixes the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants