Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only one connection to the device via PhoneAPI is allowed at any time. #526

Closed
mc-hamster opened this issue Nov 18, 2020 · 13 comments
Closed
Labels
wontfix This will not be worked on

Comments

@mc-hamster
Copy link
Member

mc-hamster commented Nov 18, 2020

Old title: ""most recently read messageNum" is kept in MeshService"

From Kevin:

There is an ugly hack in there to shutdown the BLE API whenever someone connects through another instance of PhoneAPI.

This was a mistake I made originally - the notion of "most recently read messageNum" is kept in MeshService (which is a singleton used by everyone). It really should be in PhoneAPI instead.

From Jm:

When this is rewritten, also include information so we can track which client connected to the device sent the message.

  • Did it come from BLE? Which connected device?
  • Did it come from wifi?
  • Did it come from a plugin on the device?
  • Somewhere else?
@mc-hamster mc-hamster added the bug Something isn't working label Dec 31, 2020
@geeksville
Copy link
Member

This issue has been mentioned on Meshtastic. There might be relevant details there:

https://meshtastic.discourse.group/t/webui-doesnt-show-devices-when-a-python-script-is-running/2186/2

@mc-hamster mc-hamster changed the title "most recently read messageNum" is kept in MeshService Only one connection to the device via PhoneAPI is allowed at any time. Nov 16, 2021
@mc-hamster mc-hamster added the enhancement New feature or request label Nov 21, 2021
@garthvh
Copy link
Member

garthvh commented Nov 23, 2021

Getting this bug fixed is a prerequisite to having multiple users with concurrent connections to a single device.

@garthvh
Copy link
Member

garthvh commented Nov 23, 2021

Based on some crash feedback from the iOS app it appears that some crashes that seem to be caused by doing a BLE PIN connection via the app may be caused by users trying to connect via serial and BLE being simultaneously.

@ventz
Copy link

ventz commented Nov 24, 2021

@garthvh Thanks for posting.

@geeksville I was that user :) -- I had a serial console opened on a T-Beam and was connecting via @garthvh's iOS app.

If it will be helpful to test anything specific, or provide any info/debug/etc, let me know.

@geeksville
Copy link
Member

This issue has been mentioned on Meshtastic. There might be relevant details there:

https://meshtastic.discourse.group/t/multiple-phones-connected-to-1-t-beam/4586/6

@joshpirihi
Copy link
Contributor

Does the device really need to keep a track of each client individually? it'd make it really easy if every client got every FromRadio packet, whether they asked for it or not. What issues might that cause?

@mc-hamster
Copy link
Member Author

Otherwise the client would get packets it has already seen and would need to manage state it wouldn't otherwise have to.

@joshpirihi
Copy link
Contributor

I missed the discussion on the call this morning -- I'll stay out of it until I know more about how hard this is

@mc-hamster
Copy link
Member Author

I missed the discussion on the call this morning -- I'll stay out of it until I know more about how hard this is

Don't hold back and please keep questions coming. It's better that we learn more.

@thebentern
Copy link
Contributor

@garthvh do we know if this has been resolved with the transition to the new bluetooth stack?

@garthvh
Copy link
Member

garthvh commented May 21, 2022

This is not resolved, to be honest I think this in an enhancement not a bug really. This is enabling multi user on a single device, which I think we kind of kicked way off down the road by increasing the node count. @mc-hamster is probably more authoritative on this but I suspect multi user with 80 node limit is a hard problem for the nodedb as configured to solve.

@garthvh garthvh removed the bug Something isn't working label Sep 11, 2022
@garthvh garthvh added the wontfix This will not be worked on label Oct 30, 2022
@garthvh
Copy link
Member

garthvh commented Oct 30, 2022

Closed as not practical anymore based on changes for 2.0.

@garthvh garthvh closed this as completed Oct 30, 2022
@garthvh garthvh removed the enhancement New feature or request label Oct 30, 2022
@k1n6b0b
Copy link

k1n6b0b commented Mar 19, 2024

There's a lot of discussion around use cases for multi connections

Could this be reevaluated or is it never possible?

My post from another thread---

We would use this if it became available. We fit into the multiple groups / one device per group when doing remote activities like hiking, camping, especially remote music festivals. Right now we designate one person to be the conduit and they have to proxy all coordinations. This group is price sensitive, not kidding, we’d prefer not to have to spend 20-80/pp to add this connectivity.

Any increase in # concurrent connections via wifi or Bluetooth from the mobile app to the LoRa communicator would be huge for us. We primarily use the T-Echos but have one T-Beam as a basestation at camp

Communicating as the same named user is fine. Multiple users would be ideal. But multi simultaneous connections in any fashion is the request!

Wish I could contribute in some way to this ask 🙏

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

7 participants