Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACKs not sent for retried messages #919

Closed
rxt1077 opened this issue Nov 18, 2021 · 1 comment
Closed

ACKs not sent for retried messages #919

rxt1077 opened this issue Nov 18, 2021 · 1 comment

Comments

@rxt1077
Copy link
Contributor

rxt1077 commented Nov 18, 2021

When using reliable routing (wantAck) the first packet is acknowledged, but if retries are sent they are not acknowledged. This means a single missed ACK will cause a reliable send to fail. This is in contrast to the expected behavior, stated in this comment, which is to resend an ACK for each repeated packet.

This occurs because ReliableRouter::shouldFilterRecieved calls FloodingRouter::shouldFilterRecieved which filters the packet before ReliableRouter::sniffRecieved (which handles most of the ACK logic) even sees it.

mc-hamster added a commit that referenced this issue Nov 29, 2021
ACK retried want_ack packets #919
@rxt1077 rxt1077 closed this as completed Nov 29, 2021
@geeksville
Copy link
Member

This issue has been mentioned on Meshtastic. There might be relevant details there:

https://meshtastic.discourse.group/t/meshtastic-device-1-2-48-alpha/4359/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants