Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move channel_num to LoRaConfig #203

Merged
merged 3 commits into from Oct 2, 2022
Merged

Conversation

andrekir
Copy link
Member

channel_num defines the LoRa channel frequency.

  • one single lora.channel_num users can choose for the LoRa frequency (and QR codes);
  • simplifies channel logic, making primary/secondary channel roles/index/order irrelevant.

note: when unset device still picks a random channel_num based on the primary channel hash (no change).

not a breaking change.

channel.proto Show resolved Hide resolved
config.proto Outdated Show resolved Hide resolved
Copy link
Member

@garthvh garthvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes more sense this way

@caveman99
Copy link
Sponsor Member

for the next release (1.3.42) there's a proto version increase in the code already, so the user config will be wiped anyway. i say yank it now, don't deprecate it.

@andrekir
Copy link
Member Author

andrekir commented Oct 1, 2022

reindexing channel.proto will break all previous channels url/qr codes, clients/app won't connect to any previous versions, and we'll need to reversion the url to https://www.meshtastic.org/f/#blablabla

I'd rather not turn this into a breaking change as it is mostly cosmetic, we can tag deprecated to breaking proto changes and schedule "one last breaking change" yank-fest later, if everyone agrees.

@garthvh
Copy link
Member

garthvh commented Oct 2, 2022

I agree with this approach

@sachaw sachaw self-assigned this Oct 2, 2022
@sachaw sachaw merged commit d3375fe into meshtastic:master Oct 2, 2022
@andrekir andrekir deleted the channel_num branch October 2, 2022 23:21
@geeksville
Copy link
Member

This pull request has been mentioned on Meshtastic. There might be relevant details there:

https://meshtastic.discourse.group/t/manual-channel-number-not-available-in-1-3/6635/6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants