New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move channel_num to LoRaConfig #203
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes more sense this way
for the next release (1.3.42) there's a proto version increase in the code already, so the user config will be wiped anyway. i say yank it now, don't deprecate it. |
reindexing channel.proto will break all previous channels url/qr codes, clients/app won't connect to any previous versions, and we'll need to reversion the url to https://www.meshtastic.org/f/#blablabla I'd rather not turn this into a breaking change as it is mostly cosmetic, we can tag deprecated to breaking proto changes and schedule "one last breaking change" yank-fest later, if everyone agrees. |
I agree with this approach |
This pull request has been mentioned on Meshtastic. There might be relevant details there: https://meshtastic.discourse.group/t/manual-channel-number-not-available-in-1-3/6635/6 |
channel_num
defines the LoRa channel frequency.lora.channel_num
users can choose for the LoRa frequency (and QR codes);note: when unset device still picks a random
channel_num
based on the primary channel hash (no change).not a breaking change.