[Feature Request]: Expose "Multi Click" time as a user variable #3807
rc-adammikolajczyk
started this conversation in
Ideas
Replies: 1 comment
-
I've been testing out a longer click time on my T-Echo for a week or two now and definitely think it's an improvement. The code change I've had lined up allows a custom click time to be set in a devices variant.h file, at compile time. This makes sense for a device like the T-Echo, but I can see also that your use case is different again, being a custom build. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Platform
NRF52, ESP32
Description
I've installed a user-button on my RAK19700 base board by wiring in a momentary switch between GND and AIN1 per the docs here: https://store.rokland.com/pages/adding-a-user-button-rak19007
I'm having trouble accurately making multi-clicks, however. I suspect this is more to do with the physical nature of my analog switches. Think more of a doorbell type momentary switch rather than a surface mount.
![image](https://private-user-images.githubusercontent.com/108895609/328218795-4c925d20-2c63-47d0-819f-d8265043e696.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg3NzI4ODUsIm5iZiI6MTcxODc3MjU4NSwicGF0aCI6Ii8xMDg4OTU2MDkvMzI4MjE4Nzk1LTRjOTI1ZDIwLTJjNjMtNDdkMC04MTlmLWQ4MjY1MDQzZTY5Ni5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNjE5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDYxOVQwNDQ5NDVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT00ZDUyOWQ3NTc3ZTYzN2EyNGY1MzcyMTJjMGMzMDA3ZDJkZGY4YmRhN2Q1Y2ZlYTVjOTU1ZmJmZDQ3NjA0OWUzJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.IF-latPaeseBcdL0iOiPIFkMOS9eUYjPrS6Z2_lxmcc)
If I'm not mistaken, the code shows a "click' to be a press between 1-250ms. It would be advantageous to expose that upper threshold as a user-variable, such that one might set the multi-click rate to something like 500ms - or whatever works for their particular hardware context.
firmware/src/ButtonThread.cpp
Lines 53 to 64 in 70712d8
Obviously, not a huge priority, but a nice quality of life update if it doesn't inadvertently impact other areas.
Beta Was this translation helpful? Give feedback.
All reactions