Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 224: Point of information #533

Closed
holdenweb opened this issue Mar 31, 2024 · 1 comment
Closed

PEP 224: Point of information #533

holdenweb opened this issue Mar 31, 2024 · 1 comment

Comments

@holdenweb
Copy link
Contributor

I notice that at

# Note: To follow PEP224, comments should be after the module variable.
the code assumes PEP 224 is a thing. Unfortunately, if you read the PEP you will find it was rejected, so the docstrings (for which I applaud the author) might just as well be comments. This may reduce the size of compiled files slightly, but otherwise should make absolutely no difference.

@holdenweb holdenweb changed the title PE 224: Point of information PEP 224: Point of information Mar 31, 2024
@ianmcorvidae
Copy link
Contributor

PEP224 is relevant due to our current use of pdoc, which uses them: https://pdoc3.github.io/pdoc/doc/pdoc/#docstrings-for-variables

While pdoc does support #: type comments instead, I'm not sure there's good reason to swap them over. It's possible pdoc won't serve our needs (still need to get the documentation back online in some form), at which point they could possibly be changed as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants