Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a module import view. #16

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rklyne
Copy link
Contributor

@rklyne rklyne commented Mar 23, 2020

It's visible in the test app at /deps

It's visible in the test app at `/deps`
@meshy
Copy link
Owner

meshy commented Apr 3, 2020

Thanks for this! Things are a little busy for me right now, but I will get back to look at this eventually!

Copy link

@jayvdb jayvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice idea, but on my schema with a few common infrastructure apps and django-oscar, the diagram is way to overloaded to be useful, and very slow as a result. It seems like all modules are included, and maybe even all classes. I have lots of nodes like __main__, _version, etc. I think it would be better if the first view that users are show has only nodes for distinct packages with links between them.

I would go even further and default to only include packages which are listed in INSTALLED_APPS as they are the most relevant to the user. When I view it with only a few important apps, the current graph of all nodes is useful.

I have a hard time finding apps in the sidebar - they are ordered/grouped in an unusual manner.

urlpatterns = [path("", Schema.as_view())]
urlpatterns = [
path("", Schema.as_view()),
path("deps", Schema.as_view()),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be Modules ;-)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth creating a urls.py to make it easier to include them together?

Base automatically changed from master to main March 7, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants