Skip to content

Commit

Permalink
BUG: remove -Dstrip=true default, it doesn't work on macOS
Browse files Browse the repository at this point in the history
See scipy/scipy#16446 for details
on how it fails on macOS and also for proof that it is not
needed because it does not change the wheel size on Linux.

This was originally discussed in gh-27. It looks like I was
wrong there about the need for stripping. That info was based
on my experience with `numpy.distutils` builds; there it is
needed because of the hardcoded debug flags that cannot be
switched with a flag like `-Ddebug=false` like we use in
`meson-python`.
  • Loading branch information
rgommers authored and FFY00 committed Jul 5, 2022
1 parent 60564ff commit 7783abf
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion mesonpy/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -487,7 +487,6 @@ def _configure(self, reconfigure: bool = False) -> None:
f'--native-file={os.fspath(self._meson_native_file)}',
# TODO: Allow configuring these arguments
'-Ddebug=false',
'-Dstrip=true',
'-Doptimization=2',
*setup_args,
)
Expand Down

0 comments on commit 7783abf

Please sign in to comment.